Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Steve French
Lightly updated the patch to shrink patch2 by naming a variable the same in patch 1, to avoid a rename of a local variable in patch2. And fixed one trivial checkpatch warning, and a trivial rebase issue. Tentatively merged into cifs-2.6.git for-next pending more review(s) and also the usual regre

Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Boris Protopopov
No objections on my part as far as adding 'if (info & SACL_SECINFO) return'. I had originally those flags sent from the caller, but that was confusing at the top level (e.g. in cifsacl.c), so I have opted to passing only "extra" flags ("additional" was already taken). - ... > > --- a/

Re: [PATCH 2/2] Add SMB 2 support for getting and setting SACLs

2020-12-18 Thread Shyam Prasad N
Minor comments inline... On Fri, Dec 18, 2020 at 2:30 AM Boris Protopopov wrote: > > Fix passing of the additional security info via version > operations. Force new open when getting SACL and avoid > reuse of files that were previously open without > sufficient privileges to access SACLs. > > Sig