Re: [PATCH 2/2] Fix efi_call

2016-05-16 Thread Alex Thorlton
On Thu, May 12, 2016 at 12:41:49PM +0100, Matt Fleming wrote: > On Wed, 11 May, at 02:55:45PM, Alex Thorlton wrote: > Nice. Your fix looks good, so I've put it in the urgent queue and > tagged it for stable. Great! Thanks, Matt. - Alex

Re: [PATCH 2/2] Fix efi_call

2016-05-16 Thread Alex Thorlton
On Thu, May 12, 2016 at 12:41:49PM +0100, Matt Fleming wrote: > On Wed, 11 May, at 02:55:45PM, Alex Thorlton wrote: > Nice. Your fix looks good, so I've put it in the urgent queue and > tagged it for stable. Great! Thanks, Matt. - Alex

Re: [PATCH 2/2] Fix efi_call

2016-05-16 Thread Alex Thorlton
On Thu, May 12, 2016 at 08:48:35AM +0200, Ingo Molnar wrote: > I suppose the SGI/UV code is the only one using 7 arguments or more? Might > make > sense to point that out in the changelog. First off, to everybody, sorry for the delayed responses. I've been AFK for a few days and forgot to set

Re: [PATCH 2/2] Fix efi_call

2016-05-16 Thread Alex Thorlton
On Thu, May 12, 2016 at 08:48:35AM +0200, Ingo Molnar wrote: > I suppose the SGI/UV code is the only one using 7 arguments or more? Might > make > sense to point that out in the changelog. First off, to everybody, sorry for the delayed responses. I've been AFK for a few days and forgot to set

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Matt Fleming
On Thu, 12 May, at 08:48:35AM, Ingo Molnar wrote: > > * Alex Thorlton wrote: > > > The efi_call assembly code has a slight error that prevents us from > > using arguments 7 and higher, which will be passed in on the stack. > > > > mov (%rsp), %rax > > mov

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Matt Fleming
On Thu, 12 May, at 08:48:35AM, Ingo Molnar wrote: > > * Alex Thorlton wrote: > > > The efi_call assembly code has a slight error that prevents us from > > using arguments 7 and higher, which will be passed in on the stack. > > > > mov (%rsp), %rax > > mov 8(%rax), %rax > >

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Matt Fleming
On Wed, 11 May, at 02:55:45PM, Alex Thorlton wrote: > The efi_call assembly code has a slight error that prevents us from > using arguments 7 and higher, which will be passed in on the stack. > > mov (%rsp), %rax > mov 8(%rax), %rax > ... > mov %rax, 40(%rsp) > >

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Matt Fleming
On Wed, 11 May, at 02:55:45PM, Alex Thorlton wrote: > The efi_call assembly code has a slight error that prevents us from > using arguments 7 and higher, which will be passed in on the stack. > > mov (%rsp), %rax > mov 8(%rax), %rax > ... > mov %rax, 40(%rsp) > >

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Ingo Molnar
* Alex Thorlton wrote: > The efi_call assembly code has a slight error that prevents us from > using arguments 7 and higher, which will be passed in on the stack. > > mov (%rsp), %rax > mov 8(%rax), %rax > ... > mov %rax, 40(%rsp) > > This code

Re: [PATCH 2/2] Fix efi_call

2016-05-12 Thread Ingo Molnar
* Alex Thorlton wrote: > The efi_call assembly code has a slight error that prevents us from > using arguments 7 and higher, which will be passed in on the stack. > > mov (%rsp), %rax > mov 8(%rax), %rax > ... > mov %rax, 40(%rsp) > > This code goes and grabs the