Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Yinghai Lu
On Thu, Sep 25, 2014 at 11:19 AM, Joseph Salisbury wrote: > On 09/17/2014 03:46 AM, Yinghai Lu wrote: >> On Tue, Sep 16, 2014 at 3:27 PM, Yinghai Lu wrote: >>> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury >>> wrote: A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Yinghai Lu
On Thu, Sep 25, 2014 at 8:49 AM, Joseph Salisbury wrote: > On 09/16/2014 06:27 PM, Yinghai Lu wrote: >> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury >> wrote: >>> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which >>> is similar to the original bug[1] we discussed. >>> >>

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Joseph Salisbury
On 09/17/2014 03:46 AM, Yinghai Lu wrote: > On Tue, Sep 16, 2014 at 3:27 PM, Yinghai Lu wrote: >> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury >> wrote: >>> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which >>> is similar to the original bug[1] we discussed. >>> >>> Just

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Joseph Salisbury
On 09/25/2014 12:04 PM, Bjorn Helgaas wrote: > On Thu, Sep 25, 2014 at 9:49 AM, Joseph Salisbury > wrote: >> On 09/16/2014 06:27 PM, Yinghai Lu wrote: >>> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury >>> wrote: A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Bjorn Helgaas
On Thu, Sep 25, 2014 at 9:49 AM, Joseph Salisbury wrote: > On 09/16/2014 06:27 PM, Yinghai Lu wrote: >> On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury >> wrote: >>> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which >>> is similar to the original bug[1] we discussed. >>> >>

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-25 Thread Joseph Salisbury
On 09/16/2014 06:27 PM, Yinghai Lu wrote: > On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury > wrote: >> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which >> is similar to the original bug[1] we discussed. >> >> Just wondering if there have been any additional ideas on reallo

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-24 Thread Bjorn Helgaas
On Wed, Sep 17, 2014 at 12:46:24AM -0700, Yinghai Lu wrote: > On Tue, Sep 16, 2014 at 3:27 PM, Yinghai Lu wrote: > > On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury > > wrote: > >> > >> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which > >> is similar to the original bug[1]

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-17 Thread Yinghai Lu
On Tue, Sep 16, 2014 at 3:27 PM, Yinghai Lu wrote: > On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury > wrote: >> >> A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which >> is similar to the original bug[1] we discussed. >> >> Just wondering if there have been any additional id

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-16 Thread Yinghai Lu
On Tue, Sep 16, 2014 at 1:21 PM, Joseph Salisbury wrote: > > A new bug[0] was opened due to enabling PCI_REALLOC_ENABLE_AUTO, which > is similar to the original bug[1] we discussed. > > Just wondering if there have been any additional ideas on realloc since > this was last discussed? > > [0] http:

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-09-16 Thread Joseph Salisbury
On 01/10/2014 12:13 PM, Yinghai Lu wrote: > On Fri, Jan 10, 2014 at 8:19 AM, Joseph Salisbury > wrote: >> On 12/11/2013 02:55 PM, Yinghai Lu wrote: >>> On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury >>> wrote: On 12/09/2013 03:10 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 11:42 A

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-01-10 Thread Yinghai Lu
On Fri, Jan 10, 2014 at 1:54 PM, Joseph Salisbury wrote: > On 01/10/2014 12:13 PM, Yinghai Lu wrote: > > In a prior email you mentioned: "Yes, if that works, we would not need > to put the patch in upstream for limiting realloc auto scope." Is the > git tree at > git://git.kernel.org/pub/scm/linu

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-01-10 Thread Joseph Salisbury
On 01/10/2014 12:13 PM, Yinghai Lu wrote: > On Fri, Jan 10, 2014 at 8:19 AM, Joseph Salisbury > wrote: >> On 12/11/2013 02:55 PM, Yinghai Lu wrote: >>> On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury >>> wrote: On 12/09/2013 03:10 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 11:42 A

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-01-10 Thread Yinghai Lu
On Fri, Jan 10, 2014 at 8:19 AM, Joseph Salisbury wrote: > On 12/11/2013 02:55 PM, Yinghai Lu wrote: >> On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury >> wrote: >>> On 12/09/2013 03:10 PM, Yinghai Lu wrote: On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: > That doesn't answer

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-01-10 Thread Joseph Salisbury
On 12/11/2013 02:55 PM, Yinghai Lu wrote: > On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury > wrote: >> On 12/09/2013 03:10 PM, Yinghai Lu wrote: >>> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: That doesn't answer my question at all. I understand that this change makes

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2014-01-08 Thread Joseph Salisbury
On 12/11/2013 02:55 PM, Yinghai Lu wrote: > On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury > wrote: >> On 12/09/2013 03:10 PM, Yinghai Lu wrote: >>> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: That doesn't answer my question at all. I understand that this change makes

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-11 Thread Yinghai Lu
On Wed, Dec 11, 2013 at 11:19 AM, Joseph Salisbury wrote: > On 12/09/2013 03:10 PM, Yinghai Lu wrote: >> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: >>> That doesn't answer my question at all. >>> >>> I understand that this change makes it so Joseph doesn't have to use >>> "pci=realloc=

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-11 Thread Joseph Salisbury
On 12/09/2013 03:10 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: >> That doesn't answer my question at all. >> >> I understand that this change makes it so Joseph doesn't have to use >> "pci=realloc=off". But why should auto-reallocation be limited to >> buses tha

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Bjorn Helgaas
On Mon, Dec 9, 2013 at 1:44 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 12:20 PM, Bjorn Helgaas wrote: > >> Yes, I agree. I didn't say it would be simple. The quick fix would >> be easy for now, but adding nonsensical code makes our lives harder >> long into the future. > > If the old kernel

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Yinghai Lu
On Mon, Dec 9, 2013 at 12:20 PM, Bjorn Helgaas wrote: > Yes, I agree. I didn't say it would be simple. The quick fix would > be easy for now, but adding nonsensical code makes our lives harder > long into the future. If the old kernel is working, and user update kernel then we should not reque

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Bjorn Helgaas
On Mon, Dec 9, 2013 at 1:10 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: >> That doesn't answer my question at all. >> >> I understand that this change makes it so Joseph doesn't have to use >> "pci=realloc=off". But why should auto-reallocation be limited to >>

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Yinghai Lu
On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas wrote: > That doesn't answer my question at all. > > I understand that this change makes it so Joseph doesn't have to use > "pci=realloc=off". But why should auto-reallocation be limited to > buses that have resources above 4GB? That doesn't make an

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Bjorn Helgaas
On Mon, Dec 9, 2013 at 12:20 PM, Yinghai Lu wrote: > On Mon, Dec 9, 2013 at 9:54 AM, Bjorn Helgaas wrote: >> I don't see how the question of whether the host bridge has an >> aperture above 4G is related to whether we should automatically >> reassign resources. They seem orthogonal to me. No do

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Yinghai Lu
On Mon, Dec 9, 2013 at 9:54 AM, Bjorn Helgaas wrote: > I don't see how the question of whether the host bridge has an > aperture above 4G is related to whether we should automatically > reassign resources. They seem orthogonal to me. No doubt it "fixes" > the current problem, but it doesn't make

Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

2013-12-09 Thread Bjorn Helgaas
On Sun, Dec 8, 2013 at 4:54 PM, Yinghai Lu wrote: > Joseph found > | commit b07f2ebc109b607789f648dedcff4b125f9afec6 > | Date: Thu Feb 23 19:23:32 2012 -0800 > | > |PCI: add a PCI resource reallocation config option > > cause one system can not load driver for Intel x520 NIC's. > > The root