Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-23 Thread Doug Anderson
Kees, On Wed, Apr 23, 2014 at 2:09 PM, Kees Cook wrote: > I think we can use this for the kgdb case too. Has anyone tried that > yet? Perhaps implementing text_poke() in terms of patch_map/unmap > calls would be best? Then the arm-specific kgdb hooks can use that, > since it does the icache flus

Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-23 Thread Kees Cook
On Fri, Apr 4, 2014 at 2:27 PM, Rabin Vincent wrote: > Use fixmaps for text patching when the kernel text is read-only, > inspired by x86. This makes jump labels and kprobes work with the > currently available CONFIG_DEBUG_SET_MODULE_RONX and the upcoming > CONFIG_DEBUG_RODATA options. > > Signed

Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-10 Thread Rabin Vincent
On Mon, Apr 07, 2014 at 02:57:51PM +0100, Jon Medhurst (Tixy) wrote: > How does fixmap cope with cache colouring? Looking at the implementation > it looks like it doesn't and so fixmap use on ARM is possibly buggy. > > For the text patching case where we know there are no writeable mappings > [1]

Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-08 Thread Jon Medhurst (Tixy)
On Mon, 2014-04-07 at 11:04 -0700, Kees Cook wrote: > On Mon, Apr 7, 2014 at 6:57 AM, Jon Medhurst (Tixy) wrote: > > On Fri, 2014-04-04 at 23:27 +0200, Rabin Vincent wrote: > >> Use fixmaps for text patching when the kernel text is read-only, > >> inspired by x86. This makes jump labels and kprob

Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-07 Thread Kees Cook
On Mon, Apr 7, 2014 at 6:57 AM, Jon Medhurst (Tixy) wrote: > On Fri, 2014-04-04 at 23:27 +0200, Rabin Vincent wrote: >> Use fixmaps for text patching when the kernel text is read-only, >> inspired by x86. This makes jump labels and kprobes work with the >> currently available CONFIG_DEBUG_SET_MOD

Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO

2014-04-07 Thread Jon Medhurst (Tixy)
On Fri, 2014-04-04 at 23:27 +0200, Rabin Vincent wrote: > Use fixmaps for text patching when the kernel text is read-only, > inspired by x86. This makes jump labels and kprobes work with the > currently available CONFIG_DEBUG_SET_MODULE_RONX and the upcoming > CONFIG_DEBUG_RODATA options. > > Sig