Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-17 Thread Joe Lawrence
On Tue, 17 Jun 2014 03:33:23 -0700 Christoph Hellwig wrote: > On Wed, Jun 04, 2014 at 02:07:02PM -0400, Jeff Moyer wrote: > > Wow, that's a lot more churn than I expected. ;-) I think you should go > > ahead and repost this patch with the change mentioned above (you can add > > my reviewed-by),

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-17 Thread Christoph Hellwig
On Wed, Jun 04, 2014 at 02:07:02PM -0400, Jeff Moyer wrote: > Wow, that's a lot more churn than I expected. ;-) I think you should go > ahead and repost this patch with the change mentioned above (you can add > my reviewed-by), and we can revisit this scsi one separately if people > are interested

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-04 Thread Jeff Moyer
Joe Lawrence writes: >> ITYM ret = PTR_ERR(next_rq), right? > > Oops, you are right of course. I can include this change if there should be > another version (Jens?) > >> > diff --git a/drivers/scsi/device_handler/scsi_dh_hp_sw.c >> > b/drivers/scsi/device_handler/scsi_dh_hp_sw.c >> > index 08

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Joe Lawrence
On Tue, 3 Jun 2014 16:07:01 -0400 Jeff Moyer wrote: > Joe Lawrence writes: > > > diff --git a/block/bsg.c b/block/bsg.c > > index 420a5a9..2b1c322 100644 > > --- a/block/bsg.c > > +++ b/block/bsg.c > > @@ -271,8 +271,8 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 > > *hdr, fmode_t has

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Joe Lawrence
On Tue, 3 Jun 2014 15:45:36 -0400 Jeff Moyer wrote: > Joe Lawrence writes: > > > The blk_get_request function may fail in low-memory conditions or during > > device removal (even if __GFP_WAIT is set). To distinguish between these > > errors, modify the blk_get_request call stack to return the

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Jeff Moyer
Joe Lawrence writes: > diff --git a/block/bsg.c b/block/bsg.c > index 420a5a9..2b1c322 100644 > --- a/block/bsg.c > +++ b/block/bsg.c > @@ -271,8 +271,8 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, > fmode_t has_write_perm, >* map scatter-gather elements separately and str

Re: [PATCH 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2014-06-03 Thread Jeff Moyer
Joe Lawrence writes: > The blk_get_request function may fail in low-memory conditions or during > device removal (even if __GFP_WAIT is set). To distinguish between these > errors, modify the blk_get_request call stack to return the appropriate > ERR_PTR. Verify that all callers check the return