Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Vivek Goyal
On Mon, Oct 29, 2012 at 05:45:15PM +0100, Peter Zijlstra wrote: > On Mon, 2012-10-29 at 12:38 -0400, Vivek Goyal wrote: > > Ok, so the question is what's wrong with calling synchronize_rcu() inside > > a mutex with CONFIG_PREEMPT=y. I don't know. Ccing paul mckenney and > > peterz. > > int blkcg_

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Paul E. McKenney
On Mon, Oct 29, 2012 at 12:38:45PM -0400, Vivek Goyal wrote: > On Mon, Oct 29, 2012 at 07:15:08PM +0900, Jun'ichi Nomura wrote: > > On 10/27/12 05:21, Vivek Goyal wrote: > > > On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: > > >> [PATCH] dm: stay in blk_queue_bypass until queue be

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Peter Zijlstra
On Mon, 2012-10-29 at 12:38 -0400, Vivek Goyal wrote: > Ok, so the question is what's wrong with calling synchronize_rcu() inside > a mutex with CONFIG_PREEMPT=y. I don't know. Ccing paul mckenney and > peterz. int blkcg_activate_policy(struct request_queue *q, { ... preloaded

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Vivek Goyal
On Mon, Oct 29, 2012 at 07:15:08PM +0900, Jun'ichi Nomura wrote: > On 10/27/12 05:21, Vivek Goyal wrote: > > On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: > >> [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized > >> > >> With 749fefe677 ("block: lift the initial

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Jun'ichi Nomura
On 10/27/12 05:21, Vivek Goyal wrote: > On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: >> [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized >> >> With 749fefe677 ("block: lift the initial queue bypass mode on >> blk_register_queue() instead of blk_init_allocated

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-26 Thread Vivek Goyal
On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: > [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized > > With 749fefe677 ("block: lift the initial queue bypass mode on > blk_register_queue() instead of blk_init_allocated_queue()"), > add_disk() eventually calls b

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-25 Thread Jun'ichi Nomura
On 10/25/12 18:41, Jun'ichi Nomura wrote: > With 749fefe677 ("block: lift the initial queue bypass mode on > blk_register_queue() instead of blk_init_allocated_queue()"), > add_disk() eventually calls blk_queue_bypass_end(). > This change invokes the following warning when multipath is used. ... >