Re: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Xu Yilun
On Tue, Jul 21, 2020 at 07:41:27PM +0800, Wu, Hao wrote: > > > > +} > > > > + > > > > +dfl_dev->type = feature_dev_id_type(pdev); > > > > +dfl_dev->feature_id = (unsigned long long)feature->id; > > > > + > > > > +dfl_dev->dev.parent = &pdev->dev; > > > > +dfl_dev->dev.bus = &dfl_bus_type; > >

Re: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Xu Yilun
> > +static int dfl_devs_init(struct platform_device *pdev) > > +{ > > + struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev); > > + struct dfl_feature *feature; > > + struct dfl_device *dfl_dev; > > + > > + dfl_fpga_dev_for_each_feature(pdata, feature) { > > + i

RE: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Wu, Hao
> > > +} > > > + > > > +dfl_dev->type = feature_dev_id_type(pdev); > > > +dfl_dev->feature_id = (unsigned long long)feature->id; > > > + > > > +dfl_dev->dev.parent = &pdev->dev; > > > +dfl_dev->dev.bus = &dfl_bus_type; > > > +dfl_dev->dev.release = release_dfl_dev; > > > +dev_set_name(&dfl_dev

Re: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Xu Yilun
On Fri, Jul 17, 2020 at 12:47:14PM -0700, Tom Rix wrote: > More small stuff. > > Refactoring for feature_id conflict covered in other email. > > Tom > > > On 7/14/20 10:38 PM, Xu Yilun wrote: > > A new bus type "dfl" is introduced for private features which are not > > initialized by DFL featur

Re: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Xu Yilun
On Fri, Jul 17, 2020 at 06:26:37PM +0800, Wu, Hao wrote: > > -Original Message- > > From: Xu, Yilun > > Sent: Wednesday, July 15, 2020 1:38 PM > > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > > ker...@vger.kernel.org > > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; >

Re: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-17 Thread Tom Rix
More small stuff. Refactoring for feature_id conflict covered in other email. Tom On 7/14/20 10:38 PM, Xu Yilun wrote: > A new bus type "dfl" is introduced for private features which are not > initialized by DFL feature drivers (dfl-fme & dfl-afu drivers). So these > private features could be h

RE: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-17 Thread Wu, Hao
> -Original Message- > From: Xu, Yilun > Sent: Wednesday, July 15, 2020 1:38 PM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; > Wu, Hao ; Matthew Gerlach > ; Weight, Russell H > > Subject: [PATCH