Re: [PATCH 2/2] gpio: max732x: Fix irq-events handler

2015-04-22 Thread Sam Protsenko
On Wed, Apr 22, 2015 at 10:42 AM, grygorii.stras...@linaro.org wrote: > Wouldn't handle_simple_irq() be a better choice here? You are right, thanks! I sent the new version of patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: [PATCH 2/2] gpio: max732x: Fix irq-events handler

2015-04-22 Thread grygorii.stras...@linaro.org
On 04/21/2015 08:28 PM, Semen Protsenko wrote: > MAX732X doesn't support edge type interrupt. So replace > handle_edge_irq() with handle_level_irq(), which uses > irq_mask/irq_unmask callbacks instead of irq_ack(). > > This wrong handler may lead to NULL pointer dereference in some cases. > E.g. t