RE: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-24 Thread Tirdea, Irina
gt;> To: Tirdea, Irina > >> Cc: Jonathan Cameron; linux-...@vger.kernel.org; > >> linux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana > >> Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in > >> trigger handler > >

Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-21 Thread Jonathan Cameron
ger.kernel.org; Pandruvada, Srinivas; Reus, Adriana >> Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in >> trigger handler >> >> >>> Reading all axis values in one i2c transfer reduces the delays >>> introduced by the i2c bus. In case i

Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-20 Thread Pandruvada, Srinivas
On Fri, 2015-02-20 at 16:23 +0100, Peter Meerwald wrote: > > > > > + > > > > > + values[i] = data & 0xFF; > > > > > + values[i+1] = data >> 8; > > > > > > > > this is incorrect; it forces the data to be little endian, however, the > > > > endianness (as specified in the dri

Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-20 Thread Peter Meerwald
> > > > + > > > > + values[i] = data & 0xFF; > > > > + values[i+1] = data >> 8; > > > > > > this is incorrect; it forces the data to be little endian, however, the > > > endianness (as specified in the driver's .scan_type) is IIO_CPU -- the > > > code breaks for big-en

Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-20 Thread Pandruvada, Srinivas
inux-kernel@vger.kernel.org; Pandruvada, Srinivas; Reus, Adriana > > Subject: Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in > > trigger handler > > > > > > > Reading all axis values in one i2c transfer reduces the delays > > > intr

RE: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-20 Thread Tirdea, Irina
/2] iio: accel: kxcjk-1013: optimize i2c transfers in > trigger handler > > > > Reading all axis values in one i2c transfer reduces the delays > > introduced by the i2c bus. In case i2c block read is not supported, > > fallback to reading each axis as a separate word.

Re: [PATCH 2/2] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler

2015-02-16 Thread Peter Meerwald
> Reading all axis values in one i2c transfer reduces the delays > introduced by the i2c bus. In case i2c block read is not supported, > fallback to reading each axis as a separate word. see comments inline below > Signed-off-by: Adriana Reus > Signed-off-by: Irina Tirdea > Reviewed-by: Srini