Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-22 Thread Mel Gorman
On Tue, Aug 22, 2017 at 11:21:31AM +0800, kemi wrote: > > > On 2017???08???15??? 17:58, Mel Gorman wrote: > > On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: > >> Threshold CPU cyclesThroughput(88 threads) > >> 32 799 241760478 > >> 64 640

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-21 Thread kemi
On 2017年08月15日 17:58, Mel Gorman wrote: > On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: >> Threshold CPU cyclesThroughput(88 threads) >> 32 799 241760478 >> 64 640 301628829 >> 125 537 358906028 <==> system by de

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread kemi
On 2017年08月16日 00:55, Tim Chen wrote: > On 08/15/2017 02:58 AM, Mel Gorman wrote: >> On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: >> I'm fairly sure this pushes the size of that structure into the next >> cache line which is not welcome. vm_numa_stat_diff is an always incremen

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread kemi
>> >> -static inline unsigned long zone_numa_state(struct zone *zone, >> +static inline unsigned long zone_numa_state_snapshot(struct zone *zone, >> enum zone_numa_stat_item item) >> { >> long x = atomic_long_read(&zone->vm_numa_stat[item]); >> +int

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread Mel Gorman
On Tue, Aug 15, 2017 at 10:51:21AM -0700, Tim Chen wrote: > On 08/15/2017 10:30 AM, Mel Gorman wrote: > > On Tue, Aug 15, 2017 at 09:55:39AM -0700, Tim Chen wrote: > > >> > >> Doubling the threshold and counter size will help, but not as much > >> as making them above u8 limit as seen in Kemi's da

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread Tim Chen
On 08/15/2017 10:30 AM, Mel Gorman wrote: > On Tue, Aug 15, 2017 at 09:55:39AM -0700, Tim Chen wrote: >> >> Doubling the threshold and counter size will help, but not as much >> as making them above u8 limit as seen in Kemi's data: >> >> 125 537 358906028 <==> system by defau

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread Mel Gorman
On Tue, Aug 15, 2017 at 09:55:39AM -0700, Tim Chen wrote: > On 08/15/2017 02:58 AM, Mel Gorman wrote: > > On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: > >> Threshold CPU cyclesThroughput(88 threads) > >> 32 799 241760478 > >> 64 640 3

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread Tim Chen
On 08/15/2017 02:58 AM, Mel Gorman wrote: > On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: >> Threshold CPU cyclesThroughput(88 threads) >> 32 799 241760478 >> 64 640 301628829 >> 125 537 358906028 <==> system by de

Re: [PATCH 2/2] mm: Update NUMA counter threshold size

2017-08-15 Thread Mel Gorman
On Tue, Aug 15, 2017 at 04:45:36PM +0800, Kemi Wang wrote: > Threshold CPU cyclesThroughput(88 threads) > 32 799 241760478 > 64 640 301628829 > 125 537 358906028 <==> system by default (base) > 256 468 4123