Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-05 Thread Feng Tang
Hi Chris, On Wed, Jan 06, 2021 at 03:43:36AM +, Chris Down wrote: > Feng Tang writes: > >One further thought is, there are quite some "BATCH" number in > >kernel for perf-cpu/global data updating, maybe we can add a > >global flag 'sysctl_need_accurate_stats' for > > if (sysctl_need_accura

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-05 Thread Chris Down
Chris Down writes: solution to the problem -- inclusion should at least be contingent on either having "correct-ish" stats exported to userspace. Displaying s/either//

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-05 Thread Chris Down
Feng Tang writes: One further thought is, there are quite some "BATCH" number in kernel for perf-cpu/global data updating, maybe we can add a global flag 'sysctl_need_accurate_stats' for if (sysctl_need_accurate_stats) batch = SMALLER_BATCH else bat

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-05 Thread Feng Tang
Hi Shakeel, On Tue, Jan 05, 2021 at 04:47:33PM -0800, Shakeel Butt wrote: > On Tue, Dec 29, 2020 at 6:35 AM Feng Tang wrote: > > > > When profiling memory cgroup involved benchmarking, status update > > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > > is used for both charging

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-05 Thread Shakeel Butt
On Tue, Dec 29, 2020 at 6:35 AM Feng Tang wrote: > > When profiling memory cgroup involved benchmarking, status update > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > is used for both charging and statistics/events updating, and is > set to 32, which may be good for accuracy o

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-04 Thread Feng Tang
On Mon, Jan 04, 2021 at 02:15:40PM +0100, Michal Hocko wrote: > On Tue 29-12-20 22:35:14, Feng Tang wrote: > > When profiling memory cgroup involved benchmarking, status update > > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > > is used for both charging and statistics/events u

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-04 Thread Michal Hocko
On Tue 29-12-20 22:35:14, Feng Tang wrote: > When profiling memory cgroup involved benchmarking, status update > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > is used for both charging and statistics/events updating, and is > set to 32, which may be good for accuracy of memcg c

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2021-01-03 Thread Feng Tang
Hi Roman, On Tue, Dec 29, 2020 at 09:13:27AM -0800, Roman Gushchin wrote: > On Tue, Dec 29, 2020 at 10:35:14PM +0800, Feng Tang wrote: > > When profiling memory cgroup involved benchmarking, status update > > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > > is used for both cha

Re: [PATCH 2/2] mm: memcg: add a new MEMCG_UPDATE_BATCH

2020-12-29 Thread Roman Gushchin
On Tue, Dec 29, 2020 at 10:35:14PM +0800, Feng Tang wrote: > When profiling memory cgroup involved benchmarking, status update > sometimes take quite some CPU cycles. Current MEMCG_CHARGE_BATCH > is used for both charging and statistics/events updating, and is > set to 32, which may be good for acc