Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

2017-03-08 Thread Ravi Bangoria
Thanks Masami for the review, On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote: > On Wed, 8 Mar 2017 12:29:08 +0530 > Ravi Bangoria wrote: > >> I don't see any user of this function. This function was being copied >> to tools/perf/builtin-probe.c by

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

2017-03-08 Thread Ravi Bangoria
Thanks Masami for the review, On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote: > On Wed, 8 Mar 2017 12:29:08 +0530 > Ravi Bangoria wrote: > >> I don't see any user of this function. This function was being copied >> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe:

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

2017-03-08 Thread Masami Hiramatsu
On Wed, 8 Mar 2017 12:29:08 +0530 Ravi Bangoria wrote: > I don't see any user of this function. This function was being copied > to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move > print logic into cmd_probe()"). Since then it has became

Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

2017-03-08 Thread Masami Hiramatsu
On Wed, 8 Mar 2017 12:29:08 +0530 Ravi Bangoria wrote: > I don't see any user of this function. This function was being copied > to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move > print logic into cmd_probe()"). Since then it has became stale. Hmm, I have intended to