Re: [PATCH 2/2] perf timechart: implement IO mode

2014-06-10 Thread Stanislav Fomichev
> Then I stopped to test/review. I'll review if you send v2 with fixes. Oops, sorry, I've sent an old version. Will come back with v2 and will split --io-xyz options. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH 2/2] perf timechart: implement IO mode

2014-06-10 Thread Namhyung Kim
On Mon, 9 Jun 2014 13:21:12 +0400, Stanislav Fomichev wrote: > TIMECHART OPTIONS > - > @@ -54,6 +64,15 @@ TIMECHART OPTIONS > duration or tasks with given name. If number is given it's interpreted > as number of nanoseconds. If non-numeric string is given it's >

Re: [PATCH 2/2] perf timechart: implement IO mode

2014-06-10 Thread Namhyung Kim
On Mon, 9 Jun 2014 13:21:12 +0400, Stanislav Fomichev wrote: > In IO mode timechart shows any disk/network activity. It breaks build like below: CC util/svghelper.o util/svghelper.c: In function ‘svg_ubox’: util/svghelper.c:154:91: error: declaration of ‘error’ shadows a global de

Re: [PATCH 2/2] perf timechart: implement IO mode

2014-06-09 Thread Arnaldo Carvalho de Melo
Will test the new feature soon, looks useful, thanks for working on this! Some coments about the patch below. - Arnaldo Em Mon, Jun 09, 2014 at 01:21:12PM +0400, Stanislav Fomichev escreveu: > @@ -213,7 +245,7 @@ static void pid_fork(struct timechart *tchart, int pid, > int ppid, u64 timestamp