Re: [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver

2015-03-18 Thread Uwe Kleine-König
Hello Eddie, On Wed, Mar 18, 2015 at 11:27:40AM +0800, Eddie Huang wrote: > On Tue, 2015-03-17 at 14:43 +0100, Uwe Kleine-König wrote: > > On Tue, Mar 17, 2015 at 08:31:14PM +0800, Eddie Huang wrote: > > > On Mon, 2015-03-16 at 16:30 +0100, Uwe Kleine-König wrote: > > > > On Wed, Jan 28, 2015 at 0

Re: [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver

2015-03-17 Thread Eddie Huang
Hi Uwe, On Tue, 2015-03-17 at 14:43 +0100, Uwe Kleine-König wrote: > Hello Eddie, > > On Tue, Mar 17, 2015 at 08:31:14PM +0800, Eddie Huang wrote: > > On Mon, 2015-03-16 at 16:30 +0100, Uwe Kleine-König wrote: > > > On Wed, Jan 28, 2015 at 05:27:56PM +0800, Eddie Huang wrote: > > > > [...] > > >

Re: [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver

2015-03-17 Thread Uwe Kleine-König
Hello Eddie, On Tue, Mar 17, 2015 at 08:31:14PM +0800, Eddie Huang wrote: > On Mon, 2015-03-16 at 16:30 +0100, Uwe Kleine-König wrote: > > On Wed, Jan 28, 2015 at 05:27:56PM +0800, Eddie Huang wrote: > > > [...] > > > +static u16 rtc_read(struct mt6397_rtc *rtc, u32 offset) > > rtc_read is a bad n

Re: [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver

2015-03-17 Thread Eddie Huang
Hi Uwe, Thanks your review. On Mon, 2015-03-16 at 16:30 +0100, Uwe Kleine-König wrote: > Hello Eddie, > > On Wed, Jan 28, 2015 at 05:27:56PM +0800, Eddie Huang wrote: > > From: Tianping Fang > > > > Add Mediatek MT63xx RTC driver > MT6397? Yes, it is better to use MT6397 > > diff --git a/dri

Re: [PATCH 2/2] rtc: mediatek: Add MT63xx RTC driver

2015-03-16 Thread Uwe Kleine-König
Hello Eddie, On Wed, Jan 28, 2015 at 05:27:56PM +0800, Eddie Huang wrote: > From: Tianping Fang > > Add Mediatek MT63xx RTC driver MT6397? > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index f15cddf..8ac52d8 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1427,