Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-08 Thread Paul Bolle
On Mon, 2016-11-07 at 14:38 +0100, Heiko Carstens wrote: > On Mon, Nov 07, 2016 at 02:13:06PM +0100, Paul Bolle wrote: > > --- /dev/null > > +++ b/arch/s390/include/asm/facilities.h > > @@ -0,0 +1,43 @@ > > +#ifndef __ASM_FACILITIES_H > > +#define __ASM_FACILITIES_H > > + > > +#define FACILITIES_AL

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Heiko Carstens
On Mon, Nov 07, 2016 at 02:13:06PM +0100, Paul Bolle wrote: > It took me some time to figure out that gen_facilities is only used to > generate a small header file (generated/facilities.h). And that header's only > goal is to define FACILITIES_ALS and FACILITIES_KVM. > > Pasted below is an attempt

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Paul Bolle
On Mon, 2016-11-07 at 10:50 +0100, Martin Schwidefsky wrote: > Heiko Carstens wrote: > > On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > > > > > > We generally expect headers in arch/$(ARCH)/include/asm directory > > > are included from kernel sources, but facilities_src.h is

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Martin Schwidefsky
On Mon, 7 Nov 2016 08:03:22 +0100 Heiko Carstens wrote: > On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > > We generally expect headers in arch/$(ARCH)/include/asm directory > > are included from kernel sources, but facilities_src.h is not; > > it is included from the arch/s390

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-06 Thread Heiko Carstens
On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > We generally expect headers in arch/$(ARCH)/include/asm directory > are included from kernel sources, but facilities_src.h is not; > it is included from the arch/s390/tools/gen_facilities.c tool. > > There is no reason to expose th