Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Peter Zijlstra
On Tue, 2008-01-15 at 20:18 +0300, Anton Salikhmetov wrote: > 2008/1/15, Peter Zijlstra <[EMAIL PROTECTED]>: > > > > On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote: > > > > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > > > index 3d3848f..53d0e34 100644 > > > --- a/mm/page-

Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Anton Salikhmetov
2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>: > On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote: > > +/* > > + * Update the ctime and mtime stamps for memory-mapped block device files. > > + */ > > +static void bd_inode_update_time(struct inode *inode, struct timespec *ts) > >

Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Christoph Hellwig
On Tue, Jan 15, 2008 at 07:02:45PM +0300, Anton Salikhmetov wrote: > +/* > + * Update the ctime and mtime stamps for memory-mapped block device files. > + */ > +static void bd_inode_update_time(struct inode *inode, struct timespec *ts) > +{ > + struct block_device *bdev = inode->i_bdev; > +

Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Anton Salikhmetov
2008/1/15, Peter Zijlstra <[EMAIL PROTECTED]>: > > On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote: > > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > > index 3d3848f..53d0e34 100644 > > --- a/mm/page-writeback.c > > +++ b/mm/page-writeback.c > > @@ -997,35 +997,39 @@ int __s

Re: [PATCH 2/2] Updating ctime and mtime at syncing

2008-01-15 Thread Peter Zijlstra
On Tue, 2008-01-15 at 19:02 +0300, Anton Salikhmetov wrote: > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 3d3848f..53d0e34 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -997,35 +997,39 @@ int __set_page_dirty_no_writeback(struct page *page) > */ > int _

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-15 Thread Anton Salikhmetov
2008/1/15, Miklos Szeredi <[EMAIL PROTECTED]>: > > Thanks for your review, Peter and Miklos! > > > > I overlooked this case when AS_MCTIME flag has been turned off and the > > page is still dirty. > > > > On the other hand, the words "shall be marked for update" may be > > considered as just settin

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-15 Thread Miklos Szeredi
> Thanks for your review, Peter and Miklos! > > I overlooked this case when AS_MCTIME flag has been turned off and the > page is still dirty. > > On the other hand, the words "shall be marked for update" may be > considered as just setting the AS_MCTIME flag, not updating the time > stamps. > >

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Anton Salikhmetov
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > > > > > 1) new flag triggering update of the ino

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Anton Salikhmetov
2008/1/14, Peter Zijlstra <[EMAIL PROTECTED]>: > > On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote: > > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > > > > > Changes for updating the ctime and mtime fields for memory-m

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Miklos Szeredi
> > More fun, it would require marking them RO but leaving the dirty bit > > set, because this ext3 fudge where we confuse the page dirty state - or > > did that get fixed? > > That got fixed by Nick, I think. > > The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC, > note the di

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Miklos Szeredi
> More fun, it would require marking them RO but leaving the dirty bit > set, because this ext3 fudge where we confuse the page dirty state - or > did that get fixed? That got fixed by Nick, I think. The alternative to marking pages RO, is to walk the PTEs in MS_ASYNC, note the dirty bit and mark

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Peter Zijlstra
On Mon, 2008-01-14 at 14:35 +0100, Peter Zijlstra wrote: > On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote: > > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > > > > > Changes for updating the ctime and mtime fields for

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Peter Zijlstra
On Mon, 2008-01-14 at 14:14 +0100, Miklos Szeredi wrote: > > 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > > > > > 1) new flag triggering update

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Miklos Szeredi
> 2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > > > 1) new flag triggering update of the inode data; > > > 2) new function to update ctime and mtime fo

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Anton Salikhmetov
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > > > 1) new flag triggering update of the inode data; > > > 2) new function to update ctime and mtime for

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Anton Salikhmetov
2008/1/14, Miklos Szeredi <[EMAIL PROTECTED]>: > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > 1) new flag triggering update of the inode data; > > 2) new function to update ctime and mtime for block device

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Miklos Szeredi
> > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > Changes for updating the ctime and mtime fields for memory-mapped files: > > > > 1) new flag triggering update of the inode data; > > 2) new function to update ctime and mtime for block device files; > > 3) new helper function to update

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-14 Thread Miklos Szeredi
> http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > Changes for updating the ctime and mtime fields for memory-mapped files: > > 1) new flag triggering update of the inode data; > 2) new function to update ctime and mtime for block device files; > 3) new helper function to update ctime and mtim

Re: [PATCH 2/2] updating ctime and mtime at syncing

2008-01-12 Thread Rik van Riel
On Sun, 13 Jan 2008 07:39:59 +0300 Anton Salikhmetov <[EMAIL PROTECTED]> wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > Changes for updating the ctime and mtime fields for memory-mapped files: > > 1) new flag triggering update of the inode data; > 2) new function to update ctime an