Re: [PATCH 2/2] vfs: don't allow writes to swap files

2019-08-15 Thread Darrick J. Wong
On Thu, Aug 15, 2019 at 11:41:21PM -0700, Christoph Hellwig wrote: > The new checks look fine to me, but where does the inode_drain_writes() > function come from, I can't find that in my tree anywhere. Doh. Forgot to include that patch in the series. :( /* * Flush file data before changing attr

Re: [PATCH 2/2] vfs: don't allow writes to swap files

2019-08-15 Thread Christoph Hellwig
The new checks look fine to me, but where does the inode_drain_writes() function come from, I can't find that in my tree anywhere. Also what does inode_drain_writes do about existing shared writable mapping? Do we even care about that corner case?