Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-04-11 Thread Toshi Kani
On Sat, 2016-04-09 at 04:04 +0200, Luis R. Rodriguez wrote: > On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote: > > > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > > > > > On x86 Linux code we now have ioremap_uc() that can't use MTRR behind > > > the scenes, why

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-04-11 Thread Toshi Kani
On Sat, 2016-04-09 at 04:04 +0200, Luis R. Rodriguez wrote: > On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote: > > > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > > > > > On x86 Linux code we now have ioremap_uc() that can't use MTRR behind > > > the scenes, why

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-04-08 Thread Luis R. Rodriguez
On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote: > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > On x86 Linux code we now have ioremap_uc() that can't use MTRR behind the > > scenes, why would something like this on the BIOS not be possible? That > > ultimately uses

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-04-08 Thread Luis R. Rodriguez
On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote: > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > On x86 Linux code we now have ioremap_uc() that can't use MTRR behind the > > scenes, why would something like this on the BIOS not be possible? That > > ultimately uses

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 6:07 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 16:43 -0700, Luis R. Rodriguez wrote: >> I meant to ask about the case where the option the lets a user go in a >> muck with BIOS settings to disable MTRR e xists and the user disables >> MTRR. What

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 6:07 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 16:43 -0700, Luis R. Rodriguez wrote: >> I meant to ask about the case where the option the lets a user go in a >> muck with BIOS settings to disable MTRR e xists and the user disables >> MTRR. What would happen for fan

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 16:43 -0700, Luis R. Rodriguez wrote: > On Tue, Mar 29, 2016 at 5:16 PM, Toshi Kani wrote: > > On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: > > > On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani > > > wrote: > > > > On Tue,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 16:43 -0700, Luis R. Rodriguez wrote: > On Tue, Mar 29, 2016 at 5:16 PM, Toshi Kani wrote: > > On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: > > > On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani > > > wrote: > > > > On Tue, 2016-03-29 at 10:14 -0700, Luis R.

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 5:16 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: >> On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: >> > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: >> > > On Fri, Mar 18,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 5:16 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: >> On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: >> > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: >> > > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani >> > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: > On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: > > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: > > > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani > > > wrote:  : > > > > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote: > On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: > > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: > > > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani > > > wrote:  : > > > > > > Do we really need UC for the fan? > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: >> On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: >> > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: >> > > On Mar 17, 2016

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote: > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: >> On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: >> > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: >> > > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: >> > > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: > > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: > > > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > > >  : > > > > I do

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Toshi Kani
On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote: > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: > > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: > > > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > > >  : > > > > I do not see any issue for Xen, but sure, we

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: >> On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: >> > >> > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: >> > > On Tue, Mar 15,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-29 Thread Luis R. Rodriguez
On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote: > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: >> On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: >> > >> > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: >> > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Joe Lawrence
On 03/14/2016 08:37 PM, Toshi Kani wrote: [... snip ...] >> Joe at Stratus also hit this issue but on a system where MTRR is enabled. >> He sent his report only to me as he thought it was caused by the >> ioremap_wc() changes and his driver was one that got it. In his case >> though he modified

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Joe Lawrence
On 03/14/2016 08:37 PM, Toshi Kani wrote: [... snip ...] >> Joe at Stratus also hit this issue but on a system where MTRR is enabled. >> He sent his report only to me as he thought it was caused by the >> ioremap_wc() changes and his driver was one that got it. In his case >> though he modified

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Toshi Kani
On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > > > On Tue, 2016-03-15 at 01:15

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Toshi Kani
On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote: > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > > > On Tue, 2016-03-15 at 01:15 +0100, Luis R.

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Luis R. Rodriguez
On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Luis R. Rodriguez
On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote: > > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Toshi Kani
On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > > > On Fri, 2016-03-11 at 15:34 -0800,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-19 Thread Toshi Kani
On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote: > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > > > On Fri, 2016-03-11 at 15:34 -0800,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Luis R. Rodriguez
On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Luis R. Rodriguez
On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote: > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Toshi Kani
On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani > > > wrote: > > > > On Fri, 2016-03-11

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Toshi Kani
On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani > > > wrote: > > > > On Fri, 2016-03-11 at 23:17 +0100, Luis

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Borislav Petkov
On Mon, Mar 14, 2016 at 06:37:20PM -0600, Toshi Kani wrote: > Yes, it'd be really nice if Paul can test it as well. Let's please agree on the final design of the patchset first and then ask bug reporters to test. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-15 Thread Borislav Petkov
On Mon, Mar 14, 2016 at 06:37:20PM -0600, Toshi Kani wrote: > Yes, it'd be really nice if Paul can test it as well. Let's please agree on the final design of the patchset first and then ask bug reporters to test. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > > > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > > > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > > > > On Fri, Mar 11, 2016 at 11:57:12AM -0700,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Toshi Kani
On Mon, 2016-03-14 at 23:50 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 11:34:26AM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > > * Ingo Molnar wrote:  : > > The negative effects of the issue were two failures in Xorg on

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Toshi Kani
On Mon, 2016-03-14 at 23:50 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 11:34:26AM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > > * Ingo Molnar wrote:  : > > The negative effects of the issue were two failures in Xorg on qemu32 > > env,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 11:34:26AM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > > > > * Toshi Kani wrote: > > > > > > > MTRR manages PAT initialization as it implements a rendezvous >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 11:34:26AM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > > > > * Toshi Kani wrote: > > > > > > > MTRR manages PAT initialization as it implements a rendezvous > > > > handler that initializes PAT as

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Toshi Kani
On Sat, 2016-03-12 at 17:18 +0100, Ingo Molnar wrote: > * Toshi Kani wrote: > > > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > > * Ingo Molnar wrote: > > > > > > > > > > > * Toshi Kani wrote: > > > > > > > > > MTRR

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-14 Thread Toshi Kani
On Sat, 2016-03-12 at 17:18 +0100, Ingo Molnar wrote: > * Toshi Kani wrote: > > > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > > * Ingo Molnar wrote: > > > > > > > > > > > * Toshi Kani wrote: > > > > > > > > > MTRR manages PAT initialization as it implements a rendezvous > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-12 Thread Ingo Molnar
* Toshi Kani wrote: > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > > > > * Toshi Kani wrote: > > > > > > > MTRR manages PAT initialization as it implements a rendezvous > > > > handler

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-12 Thread Ingo Molnar
* Toshi Kani wrote: > On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > > > > * Toshi Kani wrote: > > > > > > > MTRR manages PAT initialization as it implements a rendezvous > > > > handler that initializes PAT as part of MTRR initialization. > > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > > > > On Fri, 2016-03-11 at

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > > > On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > > > > On Fri, 2016-03-11 at 10:24 +0100, Borislav

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: >> On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: >> > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: >> > > On Thu, Mar 10, 2016 at

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani wrote: > On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: >> On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: >> > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: >> > > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > > > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > > > MTRR manages PAT initialization as it

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 23:17 +0100, Luis R. Rodriguez wrote: > On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > > > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > > > MTRR manages PAT initialization as it

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > > MTRR manages PAT initialization as it implements a rendezvous > > > handler that initializes PAT as part of

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Luis R. Rodriguez
On Fri, Mar 11, 2016 at 11:57:12AM -0700, Toshi Kani wrote: > On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > > MTRR manages PAT initialization as it implements a rendezvous > > > handler that initializes PAT as part of

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > MTRR manages PAT initialization as it implements a rendezvous > > handler that initializes PAT as part of MTRR initialization. > > > > When CPU does not support MTRR, ex.

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 10:24 +0100, Borislav Petkov wrote: > On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > > MTRR manages PAT initialization as it implements a rendezvous > > handler that initializes PAT as part of MTRR initialization. > > > > When CPU does not support MTRR, ex.

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > * Ingo Molnar wrote: > > > > > * Toshi Kani wrote: > > > > > MTRR manages PAT initialization as it implements a rendezvous > > > handler that initializes PAT as part of MTRR initialization. > > > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Toshi Kani
On Fri, 2016-03-11 at 09:13 +, Ingo Molnar wrote: > * Ingo Molnar wrote: > > > > > * Toshi Kani wrote: > > > > > MTRR manages PAT initialization as it implements a rendezvous > > > handler that initializes PAT as part of MTRR initialization. > > > > > > When CPU does not support MTRR,

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Borislav Petkov
On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > MTRR manages PAT initialization as it implements a rendezvous > handler that initializes PAT as part of MTRR initialization. > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > simply skips PAT init, which causes PAT

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Borislav Petkov
On Thu, Mar 10, 2016 at 09:45:46PM -0700, Toshi Kani wrote: > MTRR manages PAT initialization as it implements a rendezvous > handler that initializes PAT as part of MTRR initialization. > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > simply skips PAT init, which causes PAT

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Toshi Kani wrote: > > > MTRR manages PAT initialization as it implements a rendezvous > > handler that initializes PAT as part of MTRR initialization. > > > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > >

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Toshi Kani wrote: > > > MTRR manages PAT initialization as it implements a rendezvous > > handler that initializes PAT as part of MTRR initialization. > > > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > > simply skips PAT init, which causes PAT

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Ingo Molnar
* Toshi Kani wrote: > MTRR manages PAT initialization as it implements a rendezvous > handler that initializes PAT as part of MTRR initialization. > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > simply skips PAT init, which causes PAT left enabled without

Re: [PATCH 2/2] x86/mtrr: Refactor PAT initialization code

2016-03-11 Thread Ingo Molnar
* Toshi Kani wrote: > MTRR manages PAT initialization as it implements a rendezvous > handler that initializes PAT as part of MTRR initialization. > > When CPU does not support MTRR, ex. qemu32 virtual CPU, MTRR > simply skips PAT init, which causes PAT left enabled without > initialization.