Re: [PATCH 2/2] zram: protect zram->stat race with init_lock

2015-01-25 Thread Sergey Senozhatsky
Hello, On (01/24/15 21:17), Ganesh Mahendran wrote: > Hello Sergey > > 2015-01-23 22:38 GMT+08:00 Sergey Senozhatsky : > > On (01/23/15 14:58), Minchan Kim wrote: > >> The zram->stat handling should be procted by init_lock. > >> Otherwise, user could see stale value from the stat. > >> > >> Signe

Re: [PATCH 2/2] zram: protect zram->stat race with init_lock

2015-01-24 Thread Ganesh Mahendran
Hello Sergey 2015-01-23 22:38 GMT+08:00 Sergey Senozhatsky : > On (01/23/15 14:58), Minchan Kim wrote: >> The zram->stat handling should be procted by init_lock. >> Otherwise, user could see stale value from the stat. >> >> Signed-off-by: Minchan Kim >> --- >> >> I don't think it's stable materia

Re: [PATCH 2/2] zram: protect zram->stat race with init_lock

2015-01-23 Thread Sergey Senozhatsky
On (01/23/15 14:58), Minchan Kim wrote: > The zram->stat handling should be procted by init_lock. > Otherwise, user could see stale value from the stat. > > Signed-off-by: Minchan Kim > --- > > I don't think it's stable material. The race is rare in real practice > and this stale stat value read

Re: [PATCH 2/2] zram: protect zram->stat race with init_lock

2015-01-23 Thread Jerome Marchand
On 01/23/2015 06:58 AM, Minchan Kim wrote: > The zram->stat handling should be procted by init_lock. > Otherwise, user could see stale value from the stat. > > Signed-off-by: Minchan Kim Acked-by: Jerome Marchand signature.asc Description: OpenPGP digital signature