Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existin

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-13 Thread Stefan Roese
On 12.06.19 11:16, Andy Shevchenko wrote: On Wed, Jun 12, 2019 at 10:13:05AM +0200, Stefan Roese wrote: On 11.06.19 16:48, Andy Shevchenko wrote: On Tue, Jun 11, 2019 at 04:02:54PM +0200, Stefan Roese wrote: On 11.06.19 14:44, Andy Shevchenko wrote: On Tue, Jun 11, 2019 at 12:56:03PM +0200, S

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-13 Thread Andy Shevchenko
On Thu, Jun 13, 2019 at 07:32:39AM +0200, Stefan Roese wrote: > On 12.06.19 11:16, Andy Shevchenko wrote: > > On Wed, Jun 12, 2019 at 10:13:05AM +0200, Stefan Roese wrote: > > > On 11.06.19 16:48, Andy Shevchenko wrote: > > > Do you something like this in mind? > > > > More likely > > > > static

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2019 at 10:13:05AM +0200, Stefan Roese wrote: > On 11.06.19 16:48, Andy Shevchenko wrote: > > On Tue, Jun 11, 2019 at 04:02:54PM +0200, Stefan Roese wrote: > > > On 11.06.19 14:44, Andy Shevchenko wrote: > > > > On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > > > >

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-12 Thread Stefan Roese
On 11.06.19 16:48, Andy Shevchenko wrote: On Tue, Jun 11, 2019 at 04:02:54PM +0200, Stefan Roese wrote: On 11.06.19 14:44, Andy Shevchenko wrote: On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: static inline void serial8250_out_MCR(struct uart_8250_port *up, int value) {

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-11 Thread Andy Shevchenko
On Tue, Jun 11, 2019 at 04:02:54PM +0200, Stefan Roese wrote: > On 11.06.19 14:44, Andy Shevchenko wrote: > > On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > > > static inline void serial8250_out_MCR(struct uart_8250_port *up, int > > > value) > > > { > > > serial_ou

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-11 Thread Stefan Roese
On 11.06.19 14:44, Andy Shevchenko wrote: On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: From: Yegor Yefremov This patch permits the usage for GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI signals. static inline void serial8250_out_MCR(struct uart_8250_port *up, int value)

Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers

2019-06-11 Thread Andy Shevchenko
On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > static inline void serial8250_out_MCR(struct uart_8250_port *up, int value) > { > serial_out(up, UART_MCR, va