Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-13 Thread Wanpeng Li
On Sat, 12 Sep 2020 at 14:20, Paolo Bonzini wrote: > > On 09/09/20 10:47, Wanpeng Li wrote: > >> One more thing: > >> > >> VMX version does > >> > >> vmx_complete_interrupts(vmx); > >> if (is_guest_mode(vcpu)) > >> return EXIT_FASTPATH_NONE; > >> > >> and on SVM we

Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-11 Thread Paolo Bonzini
On 09/09/20 10:47, Wanpeng Li wrote: >> One more thing: >> >> VMX version does >> >> vmx_complete_interrupts(vmx); >> if (is_guest_mode(vcpu)) >> return EXIT_FASTPATH_NONE; >> >> and on SVM we analyze is_guest_mode() inside >> svm_exit_handlers_fastpath() - should we

Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-09 Thread Wanpeng Li
On Wed, 9 Sep 2020 at 16:36, Vitaly Kuznetsov wrote: > > Wanpeng Li writes: > > > From: Wanpeng Li > > > > Moving svm_complete_interrupts() into svm_vcpu_run() which can align VMX > > and SVM with respect to completing interrupts. > > > > Suggested-by: Sean Christopherson > > Cc: Paul K. > > S

Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-09 Thread Vitaly Kuznetsov
Wanpeng Li writes: > From: Wanpeng Li > > Moving svm_complete_interrupts() into svm_vcpu_run() which can align VMX > and SVM with respect to completing interrupts. > > Suggested-by: Sean Christopherson > Cc: Paul K. > Signed-off-by: Wanpeng Li > --- > arch/x86/kvm/svm/svm.c | 4 ++-- > 1 fi