Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-07 Thread Peter Zijlstra
On Tue, Aug 07, 2018 at 11:29:54AM -0400, Liang, Kan wrote: > On 8/6/2018 2:35 PM, Peter Zijlstra wrote: > > On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: > > > @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct > > > perf_event *event) > > > i

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:35 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event *event) if (unlikely(event->attr.precise_ip)) intel_pmu_pebs_disable(even

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 02:33:23PM -0700, Andi Kleen wrote: > On Mon, Aug 06, 2018 at 08:35:15PM +0200, Peter Zijlstra wrote: > > > +static bool disable_counter_freezing; > > > +module_param(disable_counter_freezing, bool, 0444); > > > +MODULE_PARM_DESC(disable_counter_freezing, "Disable counter fr

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-06 Thread Andi Kleen
On Mon, Aug 06, 2018 at 08:35:15PM +0200, Peter Zijlstra wrote: > > +static bool disable_counter_freezing; > > +module_param(disable_counter_freezing, bool, 0444); > > +MODULE_PARM_DESC(disable_counter_freezing, "Disable counter freezing > > feature." > > + "The PMI handler will fall bac

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: > @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event > *event) > if (unlikely(event->attr.precise_ip)) > intel_pmu_pebs_disable(event); > > + /* > + * We could disabl