Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Andy Shevchenko
On Sat, Feb 16, 2013 at 4:00 PM, Arnd Bergmann wrote: > On Saturday 16 February 2013, Andy Shevchenko wrote: >> On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann wrote: >> > + if (WARN_ON(fargs.req >= 16 || fargs.src >= 2 || fargs.dst >= 2)) >> > + return NULL; >> >> 16 here is

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Andy Shevchenko wrote: > On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann wrote: > > > @@ -168,7 +169,13 @@ static void dwc_initialize(struct dw_dma_chan *dwc) > > if (dwc->initialized == true) > > return; > > > > - if (dws) { > > + i

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Russell King - ARM Linux wrote: > On Sat, Feb 16, 2013 at 10:07:39AM +, Arnd Bergmann wrote: > > On Saturday 16 February 2013, Viresh Kumar wrote: > > > On 15 February 2013 23:51, Arnd Bergmann wrote: > > > > +static bool dw_dma_generic_filter(struct dma_chan *cha

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Andy Shevchenko
On Fri, Feb 15, 2013 at 8:21 PM, Arnd Bergmann wrote: > The original device tree binding for this driver, from Viresh Kumar > unfortunately conflicted with the generic DMA binding, and did not allow > to completely seperate slave device configuration from the controller. > > This is an attempt to

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Russell King - ARM Linux
On Sat, Feb 16, 2013 at 10:07:39AM +, Arnd Bergmann wrote: > On Saturday 16 February 2013, Viresh Kumar wrote: > > On 15 February 2013 23:51, Arnd Bergmann wrote: > > > +static bool dw_dma_generic_filter(struct dma_chan *chan, void *param) > > > { > > > > > + dws->cfg_hi = 0xff

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-16 Thread Arnd Bergmann
On Saturday 16 February 2013, Viresh Kumar wrote: > On 15 February 2013 23:51, Arnd Bergmann wrote: > > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt > > b/Documentation/devicetree/bindings/dma/snps-dma.txt > > +- #dma-cells: must be <3> > > > +DMA clients connected to the Desi

Re: [PATCH 2/4] dmaengine: dw_dmac: move to generic DMA binding

2013-02-15 Thread Viresh Kumar
On 15 February 2013 23:51, Arnd Bergmann wrote: > diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt > b/Documentation/devicetree/bindings/dma/snps-dma.txt > +- #dma-cells: must be <3> > +DMA clients connected to the Designware DMA controller must use the format > +described in the