Re: [PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-16 Thread Bjorn Andersson
On Thu 12 Oct 07:47 PDT 2017, Todor Tomov wrote: > Hi Bjorn, > > Thank you for the review. There are a lot of important suggestions. > > On 6.10.2017 08:20, Bjorn Andersson wrote: > > On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: > >> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c > >> b/dr

Re: [PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-12 Thread Todor Tomov
Hi Bjorn, Thank you for the review. There are a lot of important suggestions. On 6.10.2017 08:20, Bjorn Andersson wrote: > On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: >> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c >> b/drivers/i2c/busses/i2c-qcom-cci.c > [..] >> +#define NUM_MASTERS 1 >

Re: [PATCH 2/4] i2c: Add Qualcomm Camera Control Interface driver

2017-10-05 Thread Bjorn Andersson
On Mon 02 Oct 07:13 PDT 2017, Todor Tomov wrote: > diff --git a/drivers/i2c/busses/i2c-qcom-cci.c > b/drivers/i2c/busses/i2c-qcom-cci.c [..] > +#define NUM_MASTERS 1 So you will only register one of the masters? [..] > +enum cci_i2c_queue_t { > + QUEUE_0, > + QUEUE_1 Could these be call