Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-12 Thread Yang Shi
On 6/12/19 3:09 AM, Kirill A. Shutemov wrote: On Tue, Jun 11, 2019 at 10:06:36PM -0700, Yang Shi wrote: On 6/11/19 7:47 PM, Kirill A. Shutemov wrote: On Fri, Jun 07, 2019 at 02:07:37PM +0800, Yang Shi wrote: + /* +* The THP may be not on LRU at this point, e.g. the old page o

Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-12 Thread Kirill A. Shutemov
On Tue, Jun 11, 2019 at 10:06:36PM -0700, Yang Shi wrote: > > > On 6/11/19 7:47 PM, Kirill A. Shutemov wrote: > > On Fri, Jun 07, 2019 at 02:07:37PM +0800, Yang Shi wrote: > > > + /* > > > + * The THP may be not on LRU at this point, e.g. the old page of > > > + * NUMA migration. And PageTrans

Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-11 Thread Yang Shi
On 6/11/19 7:47 PM, Kirill A. Shutemov wrote: On Fri, Jun 07, 2019 at 02:07:37PM +0800, Yang Shi wrote: + /* +* The THP may be not on LRU at this point, e.g. the old page of +* NUMA migration. And PageTransHuge is not enough to distinguish +* with other compound

Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-11 Thread Kirill A. Shutemov
On Fri, Jun 07, 2019 at 02:07:37PM +0800, Yang Shi wrote: > + /* > + * The THP may be not on LRU at this point, e.g. the old page of > + * NUMA migration. And PageTransHuge is not enough to distinguish > + * with other compound page, e.g. skb, THP destructor is not used > +

Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-10 Thread Yang Shi
On 6/10/19 1:21 AM, Kirill Tkhai wrote: Hi, Yang, On 07.06.2019 09:07, Yang Shi wrote: Currently THP deferred split shrinker is not memcg aware, this may cause premature OOM with some configuration. For example the below test would run into premature OOM easily: $ cgcreate -g memory:thp $ e

Re: [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware

2019-06-10 Thread Kirill Tkhai
Hi, Yang, On 07.06.2019 09:07, Yang Shi wrote: > Currently THP deferred split shrinker is not memcg aware, this may cause > premature OOM with some configuration. For example the below test would > run into premature OOM easily: > > $ cgcreate -g memory:thp > $ echo 4G > /sys/fs/cgroup/memory/thp