Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-24 Thread Thomas Gleixner
On Mon, 24 Jun 2013, David Vrabel wrote: > On 24/06/13 17:30, Thomas Gleixner wrote: > > > > We already have a synchronous notifier in place and the notifier call > > itself is not expensive. What's expensive is the hypercall and there > > is no way at the moment to figure out whether the update

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-24 Thread John Stultz
On 06/24/2013 10:00 AM, David Vrabel wrote: On 24/06/13 17:30, Thomas Gleixner wrote: @@ -508,7 +509,7 @@ int do_settimeofday(const struct timespec *tv) tk_set_xtime(tk, tv); - timekeeping_update(tk, true, true); + timekeeping_update(tk, true, true, true); These three booleans i

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-24 Thread David Vrabel
On 24/06/13 17:30, Thomas Gleixner wrote: > > We already have a synchronous notifier in place and the notifier call > itself is not expensive. What's expensive is the hypercall and there > is no way at the moment to figure out whether the update is relevant > for you or just a tick. Though that's

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-24 Thread Thomas Gleixner
On Mon, 24 Jun 2013, David Vrabel wrote: > On 22/06/13 00:06, Thomas Gleixner wrote: > This patch set is fixing the rare case where a guest is started before > NTP has synced and thus sees an incorrect wallclock time which may cause > the guest to fail to boot. You're not fixing it, you are just m

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-24 Thread David Vrabel
On 22/06/13 00:06, Thomas Gleixner wrote: > On Fri, 21 Jun 2013, David Vrabel wrote: >> On 21/06/13 08:57, Thomas Gleixner wrote: >>> On Thu, 20 Jun 2013, David Vrabel wrote: >>> From: David Vrabel The high resolution timer code gets notified of step changes to the system time

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-21 Thread Thomas Gleixner
On Fri, 21 Jun 2013, David Vrabel wrote: > On 21/06/13 08:57, Thomas Gleixner wrote: > > On Thu, 20 Jun 2013, David Vrabel wrote: > > > >> From: David Vrabel > >> > >> The high resolution timer code gets notified of step changes to the > >> system time with clock_was_set() or clock_was_set_delaye

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-21 Thread John Stultz
On 06/21/2013 12:57 AM, Thomas Gleixner wrote: On Thu, 20 Jun 2013, David Vrabel wrote: From: David Vrabel The high resolution timer code gets notified of step changes to the system time with clock_was_set() or clock_was_set_delayed() calls. If other parts of the kernel require similar notif

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-21 Thread David Vrabel
On 21/06/13 08:57, Thomas Gleixner wrote: > On Thu, 20 Jun 2013, David Vrabel wrote: > >> From: David Vrabel >> >> The high resolution timer code gets notified of step changes to the >> system time with clock_was_set() or clock_was_set_delayed() calls. If >> other parts of the kernel require sim

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-21 Thread Thomas Gleixner
On Thu, 20 Jun 2013, David Vrabel wrote: > From: David Vrabel > > The high resolution timer code gets notified of step changes to the > system time with clock_was_set() or clock_was_set_delayed() calls. If > other parts of the kernel require similar notification there is no > clear place to hoo

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-20 Thread David Vrabel
On 19/06/13 17:52, John Stultz wrote: > On 06/19/2013 08:25 AM, David Vrabel wrote: >> From: David Vrabel >> >> The high resolution timer code gets notified of step changes to the >> system time with clock_was_set() or clock_was_set_delayed() calls. If >> other parts of the kernel require similar

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-19 Thread John Stultz
On 06/19/2013 10:13 AM, Konrad Rzeszutek Wilk wrote: On Wed, Jun 19, 2013 at 09:52:06AM -0700, John Stultz wrote: On 06/19/2013 08:25 AM, David Vrabel wrote: From: David Vrabel The high resolution timer code gets notified of step changes to the system time with clock_was_set() or clock_was_se

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-19 Thread Konrad Rzeszutek Wilk
On Wed, Jun 19, 2013 at 09:52:06AM -0700, John Stultz wrote: > On 06/19/2013 08:25 AM, David Vrabel wrote: > >From: David Vrabel > > > >The high resolution timer code gets notified of step changes to the > >system time with clock_was_set() or clock_was_set_delayed() calls. If > >other parts of th

Re: [PATCH 2/4] time: add a notifier chain for when the system time is stepped

2013-06-19 Thread John Stultz
On 06/19/2013 08:25 AM, David Vrabel wrote: From: David Vrabel The high resolution timer code gets notified of step changes to the system time with clock_was_set() or clock_was_set_delayed() calls. If other parts of the kernel require similar notification there is no clear place to hook into.