Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-16 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > From: Jiri Olsa > > > > When task exits we close: > > 1) all events that are installed in task > > 2) all events owned by task (via file descriptor) > > > > But we don't close children events of 2) ev

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-16 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 03:35:42PM +0200, Peter Zijlstra wrote: > On Mon, Jul 14, 2014 at 03:22:23PM +0200, Jiri Olsa wrote: > > > > if we dont do it, the event stays installed without owner and > > > > perf fork callback will be called and fail on permission checking > > > > (because of owner == N

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-15 Thread Jiri Olsa
On Tue, Jul 15, 2014 at 11:11:04AM +0200, Peter Zijlstra wrote: > On Mon, Jul 14, 2014 at 10:18:54PM +0200, Jiri Olsa wrote: > > On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > > > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > > > From: Jiri Olsa SNIP > > > >

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-15 Thread Peter Zijlstra
On Mon, Jul 14, 2014 at 10:18:54PM +0200, Jiri Olsa wrote: > On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > > From: Jiri Olsa > > > +static void perf_event_exit_children(struct perf_event *parent) > > > +{ > > > +

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > From: Jiri Olsa > > > > When task exits we close: > > 1) all events that are installed in task > > 2) all events owned by task (via file descriptor) > > > > But we

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 03:35:42PM +0200, Peter Zijlstra wrote: > On Mon, Jul 14, 2014 at 03:22:23PM +0200, Jiri Olsa wrote: > > > > if we dont do it, the event stays installed without owner and > > > > perf fork callback will be called and fail on permission checking > > > > (because of owner == N

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Peter Zijlstra
On Mon, Jul 14, 2014 at 03:22:23PM +0200, Jiri Olsa wrote: > > > if we dont do it, the event stays installed without owner and > > > perf fork callback will be called and fail on permission checking > > > (because of owner == NULL) ... so yes, I think it's needed > > > > Oh, right. Alternatively,

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 03:02:37PM +0200, Peter Zijlstra wrote: > On Mon, Jul 14, 2014 at 01:43:59PM +0200, Jiri Olsa wrote: > > On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > > > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > > > From: Jiri Olsa > > > > > > > >

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Peter Zijlstra
On Mon, Jul 14, 2014 at 01:43:59PM +0200, Jiri Olsa wrote: > On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > > From: Jiri Olsa > > > > > > When task exits we close: > > > 1) all events that are installed in task

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 01:18:33PM +0200, Peter Zijlstra wrote: > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > From: Jiri Olsa > > > > When task exits we close: > > 1) all events that are installed in task > > 2) all events owned by task (via file descriptor) > > > > But we

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-14 Thread Peter Zijlstra
On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > From: Jiri Olsa > > When task exits we close: > 1) all events that are installed in task > 2) all events owned by task (via file descriptor) > > But we don't close children events of 2) events. Those children > events stay until th

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-11 Thread Jiri Olsa
On Fri, Jul 11, 2014 at 03:23:09PM +0200, Peter Zijlstra wrote: > On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > > From: Jiri Olsa > > > > When task exits we close: > > 1) all events that are installed in task > > 2) all events owned by task (via file descriptor) > > > > But we

Re: [PATCH 2/5] perf: Destroy event's children on task exit

2014-07-11 Thread Peter Zijlstra
On Fri, Jul 11, 2014 at 01:56:19PM +0200, Jiri Olsa wrote: > From: Jiri Olsa > > When task exits we close: > 1) all events that are installed in task > 2) all events owned by task (via file descriptor) > > But we don't close children events of 2) events. Those children > events stay until th