Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense.

2016-04-14 Thread Mark Brown
On Thu, Apr 14, 2016 at 04:15:34PM +0200, Giuseppe CAVALLARO wrote: > On 4/13/2016 7:23 PM, Mark Brown wrote: > /* >* After resetting, the CONFIG_REG_PSW_ are set, this >* means 3v3 operating voltage. >* The CONFIG_LATCHED_PSW_ must be used to fix the previous >

Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense.

2016-04-14 Thread Giuseppe CAVALLARO
Hello Mark On 4/13/2016 7:23 PM, Mark Brown wrote: On Wed, Apr 13, 2016 at 09:59:00AM +0200, Giuseppe CAVALLARO wrote: On 4/13/2016 8:15 AM, Mark Brown wrote: +static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) +{ or am I missing something? Why do we need to do this anyw

Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense.

2016-04-13 Thread Mark Brown
On Wed, Apr 13, 2016 at 09:59:00AM +0200, Giuseppe CAVALLARO wrote: > On 4/13/2016 8:15 AM, Mark Brown wrote: > >>>+static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) > >>>+{ > >or am I missing something? Why do we need to do this anyway, it's very > >surprsing? > This functio

Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense.

2016-04-13 Thread Giuseppe CAVALLARO
On 4/13/2016 8:15 AM, Mark Brown wrote: >+static void st_get_satinize_powerup_voltage(struct st_vsense *vsense) >+{ >+ void __iomem *ioaddr = vsense->ioaddr; >+ u32 value = readl_relaxed(ioaddr); >+ >+ dev_dbg(vsense->dev, "Initial start-up value: (0x%08x)\n", value); >+ >+ /* Sanitize vo

Re: [PATCH 2/5] regulator: st-flashss: Add a regulator driver for flashss vsense.

2016-04-12 Thread Mark Brown
On Tue, Apr 12, 2016 at 04:16:41PM +0100, Peter Griffin wrote: > diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile > index 61bfbb9..10be29b 100644 > --- a/drivers/regulator/Makefile > +++ b/drivers/regulator/Makefile > @@ -108,6 +108,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x