Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-13 Thread Arnd Bergmann
On Wednesday 13 May 2015 10:15:35 Maxime Ripard wrote: > > Alternatively, you could leave the XOR_DESCRIPTOR_SWAP flag disabled > > and just swap the descriptors manually like a lot of other drivers > > do. You have to swap the mmio accesses anywya. > > That won't be easily doable however. > > No

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-13 Thread Maxime Ripard
On Tue, May 12, 2015 at 06:05:39PM +0200, Thomas Petazzoni wrote: > Andrew, > > On Tue, 12 May 2015 17:58:24 +0200, Andrew Lunn wrote: > > > A quick grep for marvell,orion, marvell,kirkwood and marvell,dove > > suggests it should have the - if we want to be consistent with older > > Marvell devic

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-13 Thread Maxime Ripard
Hi Arnd, On Tue, May 12, 2015 at 05:49:08PM +0200, Arnd Bergmann wrote: > On Tuesday 12 May 2015 17:37:37 Maxime Ripard wrote: > > From: Lior Amsalem > > > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Andrew Lunn
On Tue, May 12, 2015 at 05:49:36PM +0200, Thomas Petazzoni wrote: > Maxime, > > On Tue, 12 May 2015 17:37:37 +0200, Maxime Ripard wrote: > > > Required properties: > > -- compatible: Should be "marvell,orion-xor" > > +- compatible: Should be "marvell,orion-xor" or "marvell,a38x-xor" > > I belie

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Thomas Petazzoni
Andrew, On Tue, 12 May 2015 17:58:24 +0200, Andrew Lunn wrote: > A quick grep for marvell,orion, marvell,kirkwood and marvell,dove > suggests it should have the - if we want to be consistent with older > Marvell devices. As you said, starting with marvell,armanda it gets > pretty inconsistent :-(

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Arnd Bergmann
On Tuesday 12 May 2015 17:54:31 Thomas Petazzoni wrote: > Dear Arnd Bergmann, > > On Tue, 12 May 2015 17:49:08 +0200, Arnd Bergmann wrote: > > > Using > > > > if (IS_ENABLED(__BIG_ENDIAN)) > > > > here would make it more readable by avoiding the #if. Alternatively, > > you could leave th

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 May 2015 17:49:08 +0200, Arnd Bergmann wrote: > Using > > if (IS_ENABLED(__BIG_ENDIAN)) > > here would make it more readable by avoiding the #if. Alternatively, > you could leave the XOR_DESCRIPTOR_SWAP flag disabled and just swap > the descriptors manually

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Arnd Bergmann
On Tuesday 12 May 2015 17:37:37 Maxime Ripard wrote: > From: Lior Amsalem > > The Marvell Armada 38x SoC introduce new features to the XOR engine, > especially the fact that the engine mode (MEMCPY/XOR/PQ/etc) can be part of > the descriptor and not set through the controller registers. > > This

Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode

2015-05-12 Thread Thomas Petazzoni
Maxime, On Tue, 12 May 2015 17:37:37 +0200, Maxime Ripard wrote: > Required properties: > -- compatible: Should be "marvell,orion-xor" > +- compatible: Should be "marvell,orion-xor" or "marvell,a38x-xor" I believe the new compatible string should be armada-380-xor or armada380-xor. Wildcards in