Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types

2013-10-27 Thread David Miller
From: Ben Hutchings Date: Mon, 28 Oct 2013 04:51:25 + > On Mon, 2013-10-28 at 00:26 -0400, David Miller wrote: >> From: Ben Hutchings >> Date: Sun, 27 Oct 2013 21:51:44 + >> >> > - dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len); >> > + dbg(DBG_TX, "In fst_tx_dma %x %x %d

Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types

2013-10-27 Thread Ben Hutchings
On Mon, 2013-10-28 at 00:26 -0400, David Miller wrote: > From: Ben Hutchings > Date: Sun, 27 Oct 2013 21:51:44 + > > > - dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len); > > + dbg(DBG_TX, "In fst_tx_dma %x %x %d\n", (u32)skb, mem, len); > > Please use %p for the skb pointer in

Re: [PATCH 2/8] farsync: Fix confusion about DMA address and buffer offset types

2013-10-27 Thread David Miller
From: Ben Hutchings Date: Sun, 27 Oct 2013 21:51:44 + > - dbg(DBG_TX, "In fst_tx_dma %p %p %d\n", skb, mem, len); > + dbg(DBG_TX, "In fst_tx_dma %x %x %d\n", (u32)skb, mem, len); Please use %p for the skb pointer instead of casting it (which btw will introduce a warning on 64-bit). -