Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > Is it possible that there is a regression in the hid-debug stuff? The > > mapping does not seem to appear in the dmesg-output. I unfortunately > > don't have an earlier kernel available right now to verify, but now

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Jiri Kosina
On Mon, 15 Jan 2007, Simon Budig wrote: > Is it possible that there is a regression in the hid-debug stuff? The > mapping does not seem to appear in the dmesg-output. I unfortunately > don't have an earlier kernel available right now to verify, but now the > output on plugging in the device looks

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Vojtech Pavlik
On Mon, Jan 15, 2007 at 07:38:10PM +0100, Marcel Holtmann wrote: > Hi Vojtech, > > > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h. > > > > Do you think that makes sense? It's code, not a header file. > > > > > Should I wait for an updated patch that uses hid-debug.h

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Marcel Holtmann
Hi Vojtech, > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h. > > Do you think that makes sense? It's code, not a header file. > > > Should I wait for an updated patch that uses hid-debug.h again? actually that code shouldn't be in a header file at all. It should be

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Vojtech Pavlik
On Mon, Jan 15, 2007 at 05:44:26PM +0100, Jiri Kosina wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > > > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel > > > (this is where the USBHID split happened and generic HID layer was > > > introduced). Could you please reb

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > Yeah, it was easy to port over. Did the hid-debug stuff disappear > > completely? What would I use instead? > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h. > Should I wait for an upda

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Jiri Kosina
On Mon, 15 Jan 2007, Simon Budig wrote: > > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel > > (this is where the USBHID split happened and generic HID layer was > > introduced). Could you please rebase it against newer version of kernel > > and resend it? > I've updat

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel > (this is where the USBHID split happened and generic HID layer was > introduced). Could you please rebase it against newer version of kernel > and resend it? I've updated the patc

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Jiri Kosina
On Mon, 15 Jan 2007, Simon Budig wrote: > This change introduces a mapping for LED indicators between the USB HID > specification and the Linux input subsystem. The previous code properly > mapped the LEDs relevant for Keyboards, but garbeled the remaining ones. > With this change all LED enums