Re: [PATCH 20/24] block: RCU free request_queue

2013-01-08 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:42PM -0800, Tejun Heo wrote: > RCU free request_queue so that blkcg_gq->q can be dereferenced under > RCU lock. This will be used to implement hierarchical stats. > > Signed-off-by: Tejun Heo Acked-by: Vivek Goyal Vivek > --- > block/blk-sysfs.c | 9 ++

Re: [PATCH 20/24] block: RCU free request_queue

2013-01-02 Thread Tejun Heo
On Wed, Jan 02, 2013 at 01:48:15PM -0500, Vivek Goyal wrote: > On Fri, Dec 28, 2012 at 12:35:42PM -0800, Tejun Heo wrote: > > RCU free request_queue so that blkcg_gq->q can be dereferenced under > > RCU lock. This will be used to implement hierarchical stats. > > Can we just take a blkg reference

Re: [PATCH 20/24] block: RCU free request_queue

2013-01-02 Thread Vivek Goyal
On Fri, Dec 28, 2012 at 12:35:42PM -0800, Tejun Heo wrote: > RCU free request_queue so that blkcg_gq->q can be dereferenced under > RCU lock. This will be used to implement hierarchical stats. Can we just take a blkg reference on ->q in blkg_alloc() and drop that reference in blkg_free(), instead