Tejun Heo <[EMAIL PROTECTED]> writes:
> Eric W. Biederman wrote:
>>> /* Find the first parent which has valid dentry.
>>> */
>>> dentry = NULL;
>>> cur = sd;
>>> while (!(dentry = __sysfs_get_dentry(sb, cur))) {
>>> if (cur->s_flags & SYSFS_FLAG_REMOVED) {
>>>
Tejun Heo <[EMAIL PROTECTED]> writes:
> Yeah, I think using -ENOENT is better; otherwise, my little head feels
> like exploding. :-)
Ok. I think I know the feeling.
> More importantly, sysfs_get_dentry() seems like it
> would deference ERR_PTR() value. No?
I'm confused where you are referr
Eric W. Biederman wrote:
>> /* Find the first parent which has valid dentry.
>> */
>> dentry = NULL;
>> cur = sd;
>> while (!(dentry = __sysfs_get_dentry(sb, cur))) {
>> if (cur->s_flags & SYSFS_FLAG_REMOVED) {
>> dentry = ERR_PTR(-ENOENT)
Tejun Heo <[EMAIL PROTECTED]> writes:
>> +{
>> +struct sysfs_rename_struct *srs;
>> +struct super_block *sb;
>> +struct dentry *dentry;
>> +int error;
>> +
>> +list_for_each_entry(sb, &sysfs_fs_type.fs_supers, s_instances) {
>> +dentry = sysfs_get_dentry(sb, sd);
>>
Eric W. Biederman wrote:
> Welcome. I will see what I can do with respect to cleaning up
> the names.
>
> As for the return value of sysfs_get_dentry that is tricky. In particular
> I have three specific cases the code needs to deal with.
>
> - We got the dentry.
> - We did not get the dentry b
Hello,
On Tue, Aug 07, 2007 at 03:31:18PM -0600, Eric W. Biederman wrote:
> This patch modifies the sysfs_rename_dir and sysfs_move_dir
> to support multiple sysfs dentry trees rooted in different
> sysfs superblocks.
>
> Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
> +struct sysfs_renam
6 matches
Mail list logo
