Re: [PATCH 21/46] x86, mm: setup page table in top-down

2012-11-15 Thread Yinghai Lu
On Tue, Nov 13, 2012 at 12:36 PM, Yinghai Lu wrote: > On Tue, Nov 13, 2012 at 12:01 PM, H. Peter Anvin wrote: >> On 11/13/2012 11:59 AM, Yinghai Lu wrote: The changes to init_mem_mapping are a bit iffy but they aren't too unreasonable. Overall the patch is OK even though I wou

Re: [PATCH 21/46] x86, mm: setup page table in top-down

2012-11-13 Thread Yinghai Lu
On Tue, Nov 13, 2012 at 12:01 PM, H. Peter Anvin wrote: > On 11/13/2012 11:59 AM, Yinghai Lu wrote: >>> >>> The changes to init_mem_mapping are a bit iffy but they aren't too >>> unreasonable. >>> Overall the patch is OK even though I would certainly appreciate more >>> comments and better variabl

Re: [PATCH 21/46] x86, mm: setup page table in top-down

2012-11-13 Thread H. Peter Anvin
On 11/13/2012 11:59 AM, Yinghai Lu wrote: >> >> The changes to init_mem_mapping are a bit iffy but they aren't too >> unreasonable. >> Overall the patch is OK even though I would certainly appreciate more >> comments and better variable names (real_end?), see below. > > real_end is not good? > >

Re: [PATCH 21/46] x86, mm: setup page table in top-down

2012-11-13 Thread Yinghai Lu
On Tue, Nov 13, 2012 at 9:26 AM, Stefano Stabellini wrote: > On Mon, 12 Nov 2012, Yinghai Lu wrote: >> Get pgt_buf early from BRK, and use it to map PMD_SIZE from top at first. >> Then use mapped pages to map more ranges below, and keep looping until >> all pages get mapped. >> >> alloc_low_page w

Re: [PATCH 21/46] x86, mm: setup page table in top-down

2012-11-13 Thread Stefano Stabellini
On Mon, 12 Nov 2012, Yinghai Lu wrote: > Get pgt_buf early from BRK, and use it to map PMD_SIZE from top at first. > Then use mapped pages to map more ranges below, and keep looping until > all pages get mapped. > > alloc_low_page will use page from BRK at first, after that buffer is used > up, wi