Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-26 Thread Denys Vlasenko
On Sunday 25 November 2007 23:51, Roland McGrath wrote: > > Why is it defined in configuration system instead of some *.h file? > > That seems to be existing practice for this sort of thing. > I just followed what I saw. I think that if such conditional constants can be defined in header files (IO

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-26 Thread Roland McGrath
> What about the non-Intel vendors ? > Was this msr present on AMD K6 ? Geode? Winchip? VIA C3 ? > If not, then this patch isn't complete. I know modern AMD processors have it. I don't know about any others, nor off hand where to look to find out. Is there a better way to compose the "depends o

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-25 Thread Roland McGrath
> Why is it defined in configuration system instead of some *.h file? That seems to be existing practice for this sort of thing. I just followed what I saw. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-25 Thread Dave Jones
On Sun, Nov 25, 2007 at 02:08:02PM -0800, Roland McGrath wrote: > > This adds the (internal) Kconfig macro CONFIG_X86_DEBUGCTLMSR, > to be defined when configuring to support only hardware that > definitely supports MSR_IA32_DEBUGCTLMSR with the BTF flag. > > The Intel documentation says "P

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-25 Thread Denys Vlasenko
On Sunday 25 November 2007 14:08, Roland McGrath wrote: > This adds the (internal) Kconfig macro CONFIG_X86_DEBUGCTLMSR, > to be defined when configuring to support only hardware that > definitely supports MSR_IA32_DEBUGCTLMSR with the BTF flag. > > The Intel documentation says "P6 family" and late