Re: [PATCH 3/10] I386 mcheck p4 grotesque and needless warning fix.patch

2007-04-10 Thread Jesper Juhl
On 10/04/07, Zachary Amsden <[EMAIL PROTECTED]> wrote: No, just no. You do not use goto to skip a code block. You do not return an obvious variable from a singly-inlined function and give the function a return value. You don't put unexplained comments about kmalloc in code which doesn't do dyn

Re: [PATCH 3/10] I386 mcheck p4 grotesque and needless warning fix.patch

2007-04-10 Thread Chuck Ebbert
Zachary Amsden wrote: > No, just no. You do not use goto to skip a code block. You do not > return an obvious variable from a singly-inlined function and give > the function a return value. You don't put unexplained comments > about kmalloc in code which doesn't do dynamic allocation. And > you