Re: [PATCH 3/13] CLK: TI: DRA7: make return of 0 explicit

2014-05-19 Thread Tero Kristo
On 05/19/2014 10:41 AM, Dan Carpenter wrote: This one does feel like a bug in the original code as you mention. I have added the TI devs to the CC list so they can help us. Yes this is a bug, the dra7_apll_enable() should return some sort of error code if the lock fails. EBUSY maybe? -Tero

Re: [PATCH 3/13] CLK: TI: DRA7: make return of 0 explicit

2014-05-19 Thread Dan Carpenter
This one does feel like a bug in the original code as you mention. I have added the TI devs to the CC list so they can help us. regards, dan carpenter On Mon, May 19, 2014 at 06:31:05AM +0200, Julia Lawall wrote: > From: Julia Lawall > > Delete unnecessary local variable whose value is always