Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller <[EMAIL PROTECTED]> wrote: > but that's a lot of code to avoid a single stack allocation. The > whole fake file pointer thing still strikes me as a little ugly, and > you're definitely not the first one who needed this sort of hackery. > ugh A better way might be to stick a void *

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > > Hmmm you're right. Is your security work going into the next -mm? > > > > I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it > > to go through DaveM's networking tree? > > AF_RXRPC is a davem thing and "AFS: Add security

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Nate Diller
On 4/12/07, David Howells <[EMAIL PROTECTED]> wrote: Nate Diller <[EMAIL PROTECTED]> wrote: > Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? > If so, I'll

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Andrew Morton
On Thu, 12 Apr 2007 19:57:23 +0100 David Howells <[EMAIL PROTECTED]> wrote: > > Hmmm you're right. Is your security work going into the next -mm? > > I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it > to go through DaveM's networking tree? AF_RXRPC is a davem thing

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller <[EMAIL PROTECTED]> wrote: > Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? > If so, I'll just re-base this cleanup patch on that ... at the very

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Nate Diller
On 4/12/07, David Howells <[EMAIL PROTECTED]> wrote: Nate Diller <[EMAIL PROTECTED]> wrote: > -static struct page *afs_dir_get_page(struct inode *dir, unsigned long index) NAK. This conflicts with my AFS security patches, and eliminates any way of passing the key through to readpage(). Hmmm

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller <[EMAIL PROTECTED]> wrote: > -static struct page *afs_dir_get_page(struct inode *dir, unsigned long index) NAK. This conflicts with my AFS security patches, and eliminates any way of passing the key through to readpage(). David - To unsubscribe from this list: send the line

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller [EMAIL PROTECTED] wrote: -static struct page *afs_dir_get_page(struct inode *dir, unsigned long index) NAK. This conflicts with my AFS security patches, and eliminates any way of passing the key through to readpage(). David - To unsubscribe from this list: send the line

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Nate Diller
On 4/12/07, David Howells [EMAIL PROTECTED] wrote: Nate Diller [EMAIL PROTECTED] wrote: -static struct page *afs_dir_get_page(struct inode *dir, unsigned long index) NAK. This conflicts with my AFS security patches, and eliminates any way of passing the key through to readpage(). Hmmm

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller [EMAIL PROTECTED] wrote: Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? If so, I'll just re-base this cleanup patch on that ... at the very least

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Andrew Morton
On Thu, 12 Apr 2007 19:57:23 +0100 David Howells [EMAIL PROTECTED] wrote: Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? AF_RXRPC is a davem thing and

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread Nate Diller
On 4/12/07, David Howells [EMAIL PROTECTED] wrote: Nate Diller [EMAIL PROTECTED] wrote: Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? If so, I'll just

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: Hmmm you're right. Is your security work going into the next -mm? I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it to go through DaveM's networking tree? AF_RXRPC is a davem thing and AFS: Add security support and

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page

2007-04-12 Thread David Howells
Nate Diller [EMAIL PROTECTED] wrote: but that's a lot of code to avoid a single stack allocation. The whole fake file pointer thing still strikes me as a little ugly, and you're definitely not the first one who needed this sort of hackery. ugh A better way might be to stick a void * in