Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-05 Thread Leon Romanovsky
On Sun, Oct 04, 2015 at 07:04:06PM -0700, Davidlohr Bueso wrote: > On Sun, 04 Oct 2015, Leon Romanovsky wrote: > > >On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang wrote: > >>BUG_ON() already contain an unlikely compiler flag. Drop it. > >It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-04 Thread Davidlohr Bueso
On Mon, 05 Oct 2015, Geliang Tang wrote: On Sun, Oct 04, 2015 at 06:50:55PM -0700, Davidlohr Bueso wrote: On Sun, 04 Oct 2015, Geliang Tang wrote: >BUG_ON() already contain an unlikely compiler flag. Drop it. > >Signed-off-by: Geliang Tang Acked-by: Davidlohr Bueso ... but I believe you do

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-04 Thread Geliang Tang
On Sun, Oct 04, 2015 at 06:50:55PM -0700, Davidlohr Bueso wrote: > On Sun, 04 Oct 2015, Geliang Tang wrote: > > >BUG_ON() already contain an unlikely compiler flag. Drop it. > > > >Signed-off-by: Geliang Tang > > Acked-by: Davidlohr Bueso > > ... but I believe you do have some left: > > drive

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-04 Thread Davidlohr Bueso
On Sun, 04 Oct 2015, Leon Romanovsky wrote: On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang wrote: BUG_ON() already contain an unlikely compiler flag. Drop it. It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set. Yeah, but that's like the 1% of the cases -- and those probably don

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-04 Thread Davidlohr Bueso
On Sun, 04 Oct 2015, Geliang Tang wrote: BUG_ON() already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang Acked-by: Davidlohr Bueso ... but I believe you do have some left: drivers/scsi/scsi_lib.c:BUG_ON(unlikely(count > ivecs)); drivers/scsi/scsi_l

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

2015-10-04 Thread Leon Romanovsky
On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang wrote: > BUG_ON() already contain an unlikely compiler flag. Drop it. It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set. > > Signed-off-by: Geliang Tang > --- > mm/nommu.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletion