Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-18 Thread Darren Hart
(resending as the original appears not to have made it past my sent box) On Mon, 2013-07-15 at 11:34 +0300, Andy Shevchenko wrote: > On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > > special handling. Use the MinnowBoa

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-17 Thread Darren Hart
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > The AR803

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-15 Thread Darren Hart
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > The AR803

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-15 Thread Darren Hart
On Mon, 2013-07-15 at 11:34 +0300, Andy Shevchenko wrote: > On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: ... > > +/* The AR803X PHY on the MinnowBoard requires a physical pin to be toggled > > to > > + * ensure it is awake for probe and init. Request the line and reset the > > PHY. >

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-15 Thread Andy Shevchenko
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > The AR80

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-13 Thread Darren Hart
On Sat, 2013-07-13 at 10:09 -0700, Greg KH wrote: > On Sat, Jul 13, 2013 at 09:08:01AM -0700, Darren Hart wrote: ... > > I was looking at it as a quirk: > > > > " - New device IDs and quirks are also accepted." > > > > I even considered implementation as a pci quirk. I didn't because the > > PHY

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-13 Thread Greg KH
On Sat, Jul 13, 2013 at 09:08:01AM -0700, Darren Hart wrote: > On Fri, 2013-07-12 at 23:26 -0700, Greg KH wrote: > > On Fri, Jul 12, 2013 at 10:46:21PM -0700, Darren Hart wrote: > > > On Fri, 2013-07-12 at 18:17 -0700, Greg KH wrote: > > > > > --- > > > > > drivers/net/ethernet/oki-semi/pch_gbe/pc

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-13 Thread Darren Hart
On Fri, 2013-07-12 at 23:26 -0700, Greg KH wrote: > On Fri, Jul 12, 2013 at 10:46:21PM -0700, Darren Hart wrote: > > On Fri, 2013-07-12 at 18:17 -0700, Greg KH wrote: > > > On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote: > > > > The MinnowBoard uses an AR803x PHY with the PCH GBE which

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-12 Thread Greg KH
On Fri, Jul 12, 2013 at 10:46:21PM -0700, Darren Hart wrote: > On Fri, 2013-07-12 at 18:17 -0700, Greg KH wrote: > > On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote: > > > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > > > special handling. Use the MinnowBoard PCI

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-12 Thread Darren Hart
On Fri, 2013-07-12 at 18:10 -0700, Joe Perches wrote: > On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > > and add a pci_device_id.driver_data stru

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-12 Thread Darren Hart
On Fri, 2013-07-12 at 18:17 -0700, Greg KH wrote: > On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote: > > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > > and add a pci_device_id.driver_data s

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-12 Thread Greg KH
On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > Th

Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support

2013-07-12 Thread Joe Perches
On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. trivial comme