Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-12 Thread Palmer Dabbelt
On Tue, 12 Jun 2018 11:19:57 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Tue, Jun 12, 2018 at 7:12 PM, Palmer Dabbelt wrote: On Mon, 11 Jun 2018 20:00:08 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Mon, Jun 11, 2018 at 12:01:37PM -0700, Palmer Dabbelt wrote: OK, I'll try and fi

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-12 Thread Luc Van Oostenryck
On Tue, Jun 12, 2018 at 7:12 PM, Palmer Dabbelt wrote: > On Mon, 11 Jun 2018 20:00:08 PDT (-0700), luc.vanoostenr...@gmail.com wrote: >> On Mon, Jun 11, 2018 at 12:01:37PM -0700, Palmer Dabbelt wrote: >>> >>> OK, I'll try and figure out what's going on. We've had a handful of >>> headaches trying

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-12 Thread Palmer Dabbelt
On Mon, 11 Jun 2018 20:00:08 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Mon, Jun 11, 2018 at 12:01:37PM -0700, Palmer Dabbelt wrote: On Sat, 09 Jun 2018 14:42:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > On Sat, Jun 09, 2018 at 01:00:08PM -0700, Palmer Dabbelt wrote: > > On Fri,

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-11 Thread Luc Van Oostenryck
On Mon, Jun 11, 2018 at 12:01:37PM -0700, Palmer Dabbelt wrote: > On Sat, 09 Jun 2018 14:42:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > > On Sat, Jun 09, 2018 at 01:00:08PM -0700, Palmer Dabbelt wrote: > > > On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com > > > wrote

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-11 Thread Palmer Dabbelt
On Sat, 09 Jun 2018 14:42:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Sat, Jun 09, 2018 at 01:00:08PM -0700, Palmer Dabbelt wrote: On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > I tried it and ... the preprocessed asm is as expected: >.globl __asm_co

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-09 Thread Luc Van Oostenryck
On Sat, Jun 09, 2018 at 01:00:08PM -0700, Palmer Dabbelt wrote: > On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > > I tried it and ... the preprocessed asm is as expected: > > .globl __asm_copy_to_user ; .balign 4 ; __asm_copy_to_user: > > .globl __asm_copy_fr

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-09 Thread Palmer Dabbelt
On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Fri, Jun 08, 2018 at 03:33:36PM -0700, Palmer Dabbelt wrote: On Thu, 07 Jun 2018 09:51:33 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > On Thu, Jun 07, 2018 at 09:30:19AM -0700, Palmer Dabbelt wrote: > > diff --g

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-08 Thread Luc Van Oostenryck
On Fri, Jun 08, 2018 at 03:33:36PM -0700, Palmer Dabbelt wrote: > On Thu, 07 Jun 2018 09:51:33 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > > On Thu, Jun 07, 2018 at 09:30:19AM -0700, Palmer Dabbelt wrote: > > > diff --git a/arch/riscv/lib/uaccess.S b/arch/riscv/lib/uaccess.S > > > index 58fb2

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-08 Thread Palmer Dabbelt
On Thu, 07 Jun 2018 09:51:33 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Thu, Jun 07, 2018 at 09:30:19AM -0700, Palmer Dabbelt wrote: I haven't compiled this, but I think it should work. It's on the fix-sparse branch of kernel.org/palmer/linux.git . It's essentially what I was thinkin

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-07 Thread Luc Van Oostenryck
On Thu, Jun 07, 2018 at 09:30:19AM -0700, Palmer Dabbelt wrote: > > I haven't compiled this, but I think it should work. It's on the > fix-sparse branch of kernel.org/palmer/linux.git . It's essentially what I was thinking but I have some small remarks. > diff --git a/arch/riscv/include/asm/ua

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-07 Thread Atish Patra
On 6/7/18 9:30 AM, Palmer Dabbelt wrote: On Mon, 04 Jun 2018 12:28:47 PDT (-0700), atish.pa...@wdc.com wrote: On 6/4/18 12:09 PM, Luc Van Oostenryck wrote: On Mon, Jun 04, 2018 at 11:46:50AM -0700, Atish Patra wrote: On 6/1/18 8:22 AM, Luc Van Oostenryck wrote: __copy_user() is a function, wr

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-07 Thread Palmer Dabbelt
On Mon, 04 Jun 2018 12:28:47 PDT (-0700), atish.pa...@wdc.com wrote: On 6/4/18 12:09 PM, Luc Van Oostenryck wrote: On Mon, Jun 04, 2018 at 11:46:50AM -0700, Atish Patra wrote: On 6/1/18 8:22 AM, Luc Van Oostenryck wrote: __copy_user() is a function, written in assembly, used to copy memory bet

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-04 Thread Atish Patra
On 6/4/18 12:09 PM, Luc Van Oostenryck wrote: On Mon, Jun 04, 2018 at 11:46:50AM -0700, Atish Patra wrote: On 6/1/18 8:22 AM, Luc Van Oostenryck wrote: __copy_user() is a function, written in assembly, used to copy memory between kernel & user space. As such its to & from args may both take a u

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-04 Thread Luc Van Oostenryck
On Mon, Jun 04, 2018 at 11:46:50AM -0700, Atish Patra wrote: > On 6/1/18 8:22 AM, Luc Van Oostenryck wrote: > > __copy_user() is a function, written in assembly, used to copy > > memory between kernel & user space. As such its to & from args > > may both take a user pointer or a kernel pointer. > >

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-04 Thread Atish Patra
On 6/1/18 8:22 AM, Luc Van Oostenryck wrote: __copy_user() is a function, written in assembly, used to copy memory between kernel & user space. As such its to & from args may both take a user pointer or a kernel pointer. However the prototype for this function declare these two args as 'void __u