Re: compat_alloc_user_space removal, was Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-17 Thread Arnd Bergmann
On Sun, Sep 13, 2020 at 1:46 PM Arnd Bergmann wrote: > > On Sun, Sep 13, 2020 at 8:50 AM Christoph Hellwig wrote: > > > > On Sat, Sep 12, 2020 at 02:49:05PM +0200, Arnd Bergmann wrote: > > > fs/quota/compat.c: dqblk = compat_alloc_user_space(sizeof(struct > > > if_dqblk)); > > > fs/quota/compat.

Re: compat_alloc_user_space removal, was Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-17 Thread Christoph Hellwig
On Thu, Sep 17, 2020 at 04:55:49PM +0200, Arnd Bergmann wrote: > Unfortunately, the commit b902bfb3f0e "arm64: stop using > directly" seems to introduce a circular header file inclusion between > linux/compat.h and asm/stat.h, breaking arm64 compilation. > > Moving the compat_u64/compat_s64 defin

Re: compat_alloc_user_space removal, was Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-13 Thread Arnd Bergmann
On Sun, Sep 13, 2020 at 8:50 AM Christoph Hellwig wrote: > > On Sat, Sep 12, 2020 at 02:49:05PM +0200, Arnd Bergmann wrote: > > fs/quota/compat.c: dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); > > fs/quota/compat.c: dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); > > fs/quota

compat_alloc_user_space removal, was Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-12 Thread Christoph Hellwig
On Sat, Sep 12, 2020 at 02:49:05PM +0200, Arnd Bergmann wrote: > fs/quota/compat.c: dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); > fs/quota/compat.c: dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); > fs/quota/compat.c: fsqstat = compat_alloc_user_space(sizeof(struct > fs_quot

Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-12 Thread Arnd Bergmann
On Sat, Sep 12, 2020 at 9:48 AM Christoph Hellwig wrote: > > On Tue, Sep 08, 2020 at 11:36:23PM +0200, Arnd Bergmann wrote: > > There have been several attempts to fix serious problems > > in the compat handling in megasas_mgmt_compat_ioctl_fw(), > > and it also uses the compat_alloc_user_space()

Re: [PATCH 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-12 Thread Christoph Hellwig
On Tue, Sep 08, 2020 at 11:36:23PM +0200, Arnd Bergmann wrote: > There have been several attempts to fix serious problems > in the compat handling in megasas_mgmt_compat_ioctl_fw(), > and it also uses the compat_alloc_user_space() function. I just looked into this a few weeks ago but didn't get th