Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-09 Thread Ulf Hansson
On 8 September 2016 at 19:38, Kevin Hilman wrote: > Ulf Hansson writes: > >> [...] >> >>> >>> One more idea... >>> >>> Since you don't really have a domain (a group of devices), what you >>> really have is each device having an independent power switch, so as Ulf >>> suggested, what you really ne

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-08 Thread Dave Gerlach
Hi, On 09/08/2016 12:38 PM, Kevin Hilman wrote: Ulf Hansson writes: [...] One more idea... Since you don't really have a domain (a group of devices), what you really have is each device having an independent power switch, so as Ulf suggested, what you really need is for all the devices to

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-08 Thread Kevin Hilman
Ulf Hansson writes: > [...] > >> >> One more idea... >> >> Since you don't really have a domain (a group of devices), what you >> really have is each device having an independent power switch, so as Ulf >> suggested, what you really need is for all the devices to share the same >> set of runtime

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-08 Thread Ulf Hansson
[...] > > One more idea... > > Since you don't really have a domain (a group of devices), what you > really have is each device having an independent power switch, so as Ulf > suggested, what you really need is for all the devices to share the same > set of runtime PM callbacks that call SCI. The

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-08 Thread Ulf Hansson
> >> Here are some ideas which could be used to solve the problem differently. >> >> *) >> Assuming each platform device has a driver for it!? >> Then why don't you implement the ->runtime_suspend|resume() callbacks >> on the driver level and call the SCI interface to power on/off the >> device fro

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-07 Thread Kevin Hilman
Dave Gerlach writes: > On 08/30/2016 03:26 PM, Ulf Hansson wrote: >> On 30 August 2016 at 21:43, Dave Gerlach wrote: >>> Jon, Ulf, >>> >>> On 08/26/2016 06:37 PM, Dave Gerlach wrote: Hi, On 08/25/2016 02:27 AM, Ulf Hansson wrote: > > + Jon > > [...] > >> +

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-09-06 Thread Dave Gerlach
On 08/30/2016 03:26 PM, Ulf Hansson wrote: On 30 August 2016 at 21:43, Dave Gerlach wrote: Jon, Ulf, On 08/26/2016 06:37 PM, Dave Gerlach wrote: Hi, On 08/25/2016 02:27 AM, Ulf Hansson wrote: + Jon [...] + +static int ti_sci_pm_domains_probe(struct platform_device *pdev) +{ + stru

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-08-30 Thread Ulf Hansson
On 30 August 2016 at 21:43, Dave Gerlach wrote: > Jon, Ulf, > > On 08/26/2016 06:37 PM, Dave Gerlach wrote: >> >> Hi, >> On 08/25/2016 02:27 AM, Ulf Hansson wrote: >>> >>> + Jon >>> >>> [...] >>> + +static int ti_sci_pm_domains_probe(struct platform_device *pdev) +{ + str

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-08-30 Thread Dave Gerlach
Jon, Ulf, On 08/26/2016 06:37 PM, Dave Gerlach wrote: Hi, On 08/25/2016 02:27 AM, Ulf Hansson wrote: + Jon [...] + +static int ti_sci_pm_domains_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev->of_node; + struct ti_sci

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-08-26 Thread Dave Gerlach
Hi, On 08/25/2016 02:27 AM, Ulf Hansson wrote: > + Jon > > [...] > >> + >> +static int ti_sci_pm_domains_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct device_node *np = dev->of_node; >> + struct ti_sci_genpd_data *ti_sci_genpd; >> + >>

Re: [PATCH 3/3] soc: ti: Add ti_sci_pm_domains driver

2016-08-25 Thread Ulf Hansson
+ Jon [...] > + > +static int ti_sci_pm_domains_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + struct ti_sci_genpd_data *ti_sci_genpd; > + > + ti_sci_genpd = devm_kzalloc(dev, sizeof(*ti_sci_genp