Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Al Viro
On Sun, Jan 28, 2018 at 10:50:31PM +, Al Viro wrote: > On Sun, Jan 28, 2018 at 12:42:24PM -0800, Linus Torvalds wrote: > > > The 64-bit argument for 32-bit case would end up having to have a few > > more of those architecture-specific oddities. So not just > > "argument1(ptregs)", but "argumen

Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Al Viro
On Sun, Jan 28, 2018 at 12:42:24PM -0800, Linus Torvalds wrote: > The 64-bit argument for 32-bit case would end up having to have a few > more of those architecture-specific oddities. So not just > "argument1(ptregs)", but "argument2_32_64(ptregs)" or something that > says "get me argument 2, when

Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Linus Torvalds
On Sun, Jan 28, 2018 at 12:21 PM, Al Viro wrote: > > ... and have more of that logics arch-dependent than one might expect; > it's *not* just "split each 64bit argument into a pair of 32bit ones, > combine in the body". Right. The paired registers tend to have special arch-specific rules, making

Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Al Viro
On Sun, Jan 28, 2018 at 11:15:15AM -0800, Linus Torvalds wrote: > Is that "long long" part of the example on purpose? Because that's > likely the only really nasty part about any ptregs wrapper: some > arguments aren't _one_ register, they are two. And "long long" is the > simplest example, even th

Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Ingo Molnar
* Andy Lutomirski wrote: > __SYSCALL_DEFINE is rather magical. Add a bit of documentation. > > Signed-off-by: Andy Lutomirski > --- > include/linux/syscalls.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > index a78

Re: [PATCH 3/3] syscalls: Add a bit of documentation to __SYSCALL_DEFINE

2018-01-28 Thread Linus Torvalds
On Sun, Jan 28, 2018 at 10:38 AM, Andy Lutomirski wrote: > __SYSCALL_DEFINE is rather magical. Add a bit of documentation. Ack. Is that "long long" part of the example on purpose? Because that's likely the only really nasty part about any ptregs wrapper: some arguments aren't _one_ register, th