Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-04 Thread Chris Ruehl
On Wednesday, December 04, 2013 05:49 PM, Heikki Krogerus wrote: Hi Chris, On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote: On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote: On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: @@ -154,6 +164,27 @@ int usb_ph

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-04 Thread Heikki Krogerus
Hi Chris, On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote: > On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote: > >On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: > >>@@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct > >>usb_phy_gen_xc

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-03 Thread Chris Ruehl
On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote: On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: @@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_gen_xceiv *nop, { int err; + if (nop->ulpi_vbus> 0) { +

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-03 Thread Heikki Krogerus
On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: > @@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct > usb_phy_gen_xceiv *nop, > { > int err; > > + if (nop->ulpi_vbus > 0) { > + unsigned int flags = 0; > + > + if (nop->ulpi_

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Chris Ruehl
On Tuesday, December 03, 2013 02:22 AM, Mark Rutland wrote: On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: usb: phy-generic: Add ULPI VBUS support Some platforms need to set the VBUS parameters of the ULPI like ISP1504 which interact with overcurrent protection and power switch

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Chris Ruehl
On Tuesday, December 03, 2013 02:22 AM, Mark Rutland wrote: On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: usb: phy-generic: Add ULPI VBUS support Some platforms need to set the VBUS parameters of the ULPI like ISP1504 which interact with overcurrent protection and power switch MI

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Mark Rutland
On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: > usb: phy-generic: Add ULPI VBUS support > > Some platforms need to set the VBUS parameters of the ULPI > like ISP1504 which interact with overcurrent protection and > power switch MIC2575. Therefore it requires to set > * DRVVBUS > * D