Re: [PATCH 3/4] proc: simplify remove_proc_entry() wrt locking

2007-11-23 Thread Alexey Dobriyan
On Tue, Nov 20, 2007 at 08:08:42PM -0800, Andrew Morton wrote: > On Fri, 16 Nov 2007 18:10:15 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > We can take proc_subdir_lock for duration of list searching and removing > > from lists only. It can't hurt -- we can gather any amount of looked up

Re: [PATCH 3/4] proc: simplify remove_proc_entry() wrt locking

2007-11-23 Thread Alexey Dobriyan
On Tue, Nov 20, 2007 at 08:08:42PM -0800, Andrew Morton wrote: On Fri, 16 Nov 2007 18:10:15 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: We can take proc_subdir_lock for duration of list searching and removing from lists only. It can't hurt -- we can gather any amount of looked up PDEs

Re: [PATCH 3/4] proc: simplify remove_proc_entry() wrt locking

2007-11-20 Thread Andrew Morton
On Fri, 16 Nov 2007 18:10:15 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > We can take proc_subdir_lock for duration of list searching and removing > from lists only. It can't hurt -- we can gather any amount of looked up > PDEs right after proc_subdir_lock droppage in proc_lookup() anyway.

Re: [PATCH 3/4] proc: simplify remove_proc_entry() wrt locking

2007-11-20 Thread Andrew Morton
On Fri, 16 Nov 2007 18:10:15 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: We can take proc_subdir_lock for duration of list searching and removing from lists only. It can't hurt -- we can gather any amount of looked up PDEs right after proc_subdir_lock droppage in proc_lookup() anyway.