Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-12-05 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > On Mon, Dec 03, 2012 at 06:01:25PM +, Serge E. Hallyn wrote: > > First, generally, I don't think 'allows' added to parent should be > > automatically propagated to descendents. > > that's what I think too and what I tried to do > > > In devcgroup

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-12-03 Thread Aristeu Rozanski
On Mon, Dec 03, 2012 at 06:01:25PM +, Serge E. Hallyn wrote: > First, generally, I don't think 'allows' added to parent should be > automatically propagated to descendents. that's what I think too and what I tried to do > In devcgroup_update_access: (around line 625) > there is a perio

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-12-03 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > On Thu, Nov 29, 2012 at 08:26:08PM +, Serge E. Hallyn wrote: > > Quoting Aristeu Rozanski (a...@redhat.com): > > > I see your point. it's indeed a problem. in dev_exception_add(), it > > > needs to check for permissions before actually adding to > >

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Aristeu Rozanski
On Thu, Nov 29, 2012 at 08:26:08PM +, Serge E. Hallyn wrote: > Quoting Aristeu Rozanski (a...@redhat.com): > > I see your point. it's indeed a problem. in dev_exception_add(), it > > needs to check for permissions before actually adding to > > devcgroup->exceptions. actually, checked again, it

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > > Quoting Aristeu Rozanski (a...@redhat.com): > > > In preparation for better hierarchy support, it's needed to retain the > > > local > > > settings in order to try to reapply them aft

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Aristeu Rozanski
On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > thanks for doing this. I've got one concern though. I don't see > any place where devcgroup_create() was updated to create the > local exceptions list. I think we need a guarantee that at > any time the local exceptions list will

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Aristeu Rozanski
On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > Quoting Aristeu Rozanski (a...@redhat.com): > > In preparation for better hierarchy support, it's needed to retain the local > > settings in order to try to reapply them after a propagated change if > > they're > > still valid. > >

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > In preparation for better hierarchy support, it's needed to retain the local > settings in order to try to reapply them after a propagated change if they're > still valid. > > Cc: Tejun Heo > Cc: Serge Hallyn > Signed-off-by: Aristeu Rozanski > >