Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Brian Norris
On Wed, Nov 23, 2016 at 11:03:33AM +0800, Caesar Wang wrote: > 在 2016年11月23日 10:33, Brian Norris 写道: > >IIUC, "too high" should not be interpreted as TSADCV2_DATA_MASK on > >rk3288, should it? That corresponds to -40C, which means you'll be > >triggering the alarm temperature at a very *low* temper

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Caesar Wang
在 2016年11月23日 10:33, Brian Norris 写道: On Wed, Nov 23, 2016 at 10:06:15AM +0800, Caesar Wang wrote: 在 2016年11月23日 05:52, Brian Norris 写道: On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: + if (temp < table->id[low].temp || temp > table->id[high].temp) goto e

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Brian Norris
On Wed, Nov 23, 2016 at 10:06:15AM +0800, Caesar Wang wrote: > 在 2016年11月23日 05:52, Brian Norris 写道: > >On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: > >>>+ if (temp < table->id[low].temp || temp > table->id[high].temp) > >>> goto exit; > >I was revisiting the logic here

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Caesar Wang
在 2016年11月23日 05:52, Brian Norris 写道: On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: On Tue, Nov 22, 2016 at 08:34:46PM +0800, Caesar Wang wrote: The temp_to_code function will return 0 when we set the trip points value or valid temperature. I'm not quite sure what you mean by "

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Brian Norris
On Tue, Nov 22, 2016 at 12:57:37PM -0800, Brian Norris wrote: > On Tue, Nov 22, 2016 at 08:34:46PM +0800, Caesar Wang wrote: > > The temp_to_code function will return 0 when we set the trip points value > > or valid temperature. > > I'm not quite sure what you mean by "when we set the trip points

Re: [PATCH 3/5] thermal: rockchip: fixes invalid temperature case

2016-11-22 Thread Brian Norris
On Tue, Nov 22, 2016 at 08:34:46PM +0800, Caesar Wang wrote: > The temp_to_code function will return 0 when we set the trip points value > or valid temperature. I'm not quite sure what you mean by "when we set the trip points value or valid temperature." Do you mean "when we set the trip point's v