Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-07-05 Thread Daniel Lezcano
On 07/05/2016 10:21 AM, Wan Zongshun wrote: [ ... ] >>> +setup_irq(irq, &nuc970_timer0_irq); >> >> s/setup_irq/request_irq/ > > Do you think I should use request_irq instead of setup_irq? Yes. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-07-05 Thread Wan Zongshun
On 2016年06月28日 03:46, Daniel Lezcano wrote: On 06/25/2016 12:37 PM, Wan Zongshun wrote: This patch is to add nuc970 clocksource driver support. Hi Wan, add a detailed description of how works this timer and its general design. If there is a pointer or a reference to a manual that would be a

Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-07-05 Thread Wan Zongshun
On 2016年06月29日 23:25, Arnd Bergmann wrote: On Saturday, June 25, 2016 6:37:19 PM CEST Wan Zongshun wrote: This patch is to add nuc970 clocksource driver support. Signed-off-by: Wan Zongshun --- .../mach-w90x900/include/mach/nuc970-regs-timer.h | 44 + drivers/clocksource/Kconfig

Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-06-29 Thread Daniel Lezcano
On 06/29/2016 05:25 PM, Arnd Bergmann wrote: On Saturday, June 25, 2016 6:37:19 PM CEST Wan Zongshun wrote: This patch is to add nuc970 clocksource driver support. Signed-off-by: Wan Zongshun --- .../mach-w90x900/include/mach/nuc970-regs-timer.h | 44 + drivers/clocksource/Kconfig

Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-06-29 Thread Arnd Bergmann
On Saturday, June 25, 2016 6:37:19 PM CEST Wan Zongshun wrote: > This patch is to add nuc970 clocksource driver support. > > Signed-off-by: Wan Zongshun > --- > .../mach-w90x900/include/mach/nuc970-regs-timer.h | 44 + > drivers/clocksource/Kconfig| 8 + > drivers

Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver

2016-06-27 Thread Daniel Lezcano
On 06/25/2016 12:37 PM, Wan Zongshun wrote: This patch is to add nuc970 clocksource driver support. Hi Wan, add a detailed description of how works this timer and its general design. If there is a pointer or a reference to a manual that would be awesome. Signed-off-by: Wan Zongshun ---