Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of cred_guard_mutex

2020-05-10 Thread Kees Cook
On Sat, May 09, 2020 at 12:18:06PM -0700, Linus Torvalds wrote: > On Fri, May 8, 2020 at 11:48 AM Eric W. Biederman > wrote: > > > > > > Oleg modified the code that did > > "mutex_lock_interruptible(¤t->cred_guard_mutex)" to return > > -ERESTARTNOINTR instead of -EINTR, so that userspace will nev

Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of cred_guard_mutex

2020-05-09 Thread Eric W. Biederman
Linus Torvalds writes: > On Fri, May 8, 2020 at 11:48 AM Eric W. Biederman > wrote: >> >> >> Oleg modified the code that did >> "mutex_lock_interruptible(¤t->cred_guard_mutex)" to return >> -ERESTARTNOINTR instead of -EINTR, so that userspace will never see a >> failure to grab the mutex. >> >>

Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of cred_guard_mutex

2020-05-09 Thread Linus Torvalds
On Fri, May 8, 2020 at 11:48 AM Eric W. Biederman wrote: > > > Oleg modified the code that did > "mutex_lock_interruptible(¤t->cred_guard_mutex)" to return > -ERESTARTNOINTR instead of -EINTR, so that userspace will never see a > failure to grab the mutex. > > Slightly earlier Liam R. Howlett defi

Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of cred_guard_mutex

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:45:25PM -0500, Eric W. Biederman wrote: > > Oleg modified the code that did > "mutex_lock_interruptible(¤t->cred_guard_mutex)" to return > -ERESTARTNOINTR instead of -EINTR, so that userspace will never see a > failure to grab the mutex. > > Slightly earlier Liam R. How